New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use instance availability zone for AWS EBS #10181
Conversation
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
@justinsb is this something you'd want for v1 or can it wait? |
I think this is a good change; it is much more user-friendly. This is a breaking change for anyone using volumes also; so it might be better to just treat this as a shortcut: so vol-12345678 is a shortcut for aws:///vol-12345678, which is itself a shortcut for aws:///vol-12345678. That way we don't break any docs / blogs etc. @swagiaal this is just to be more user-friendly, right (it isn't a correctness issue)? I think we should still do it if we can accept both forms. |
Signed-off-by: Sami Wagiaalla <swagiaal@redhat.com>
@justinsb yeah this is just for the purpose of being more user friendly. |
This is nice; much more user-friendly and doesn't break anything. LGTM |
This seems pretty isolated to aws, and it sounds like we want it for 1.0 if possible. @quinton-hoole for ok-to-merge. |
Yup, ok-to-merge, thanks! |
Use instance availability zone for AWS EBS
Hey, I think https://github.com/kubernetes/kubernetes/blob/release-1.1/docs/user-guide/volumes.md#aws-ebs-example-configuration needs an update in this case :) |
filed bug at #17957 |
This simplifies the volumeID line and makes it similar to the pdName entry for GCE Persistent disks.
@justinsb What do you think of this ?