Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubelet: do not propogate an error with startContainer on deleted pods #101919

Closed
wants to merge 1 commit into from
Closed

kubelet: do not propogate an error with startContainer on deleted pods #101919

wants to merge 1 commit into from

Conversation

rphillips
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

Similar to #98933 where we fix Sandbox creation and deletion races, this PR does not propagate an error when startContainer fails on a deleted pod.

Red Hat Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1959495

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 11, 2021
@k8s-ci-robot
Copy link
Contributor

@rphillips: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 11, 2021
@rphillips
Copy link
Member Author

/sig node

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rphillips
To complete the pull request process, please assign yujuhong after the PR has been reviewed.
You can assign the PR to them by writing /assign @yujuhong in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ehashman
Copy link
Member

Unit test failure reported as #101927.

Can we get a unit test for this? :)

@ehashman ehashman added this to Triage in SIG Node PR Triage May 12, 2021
SergeyKanzhelev
SergeyKanzhelev reviewed May 12, 2021
View reviewed changes
pkg/kubelet/kuberuntime/kuberuntime_manager.go
// being created. If the pod has been deleted then it's
// not a real error.
if m.podStateProvider.IsPodDeleted(pod.UID) {
klog.V(4).InfoS("Pod was deleted and startContainer failed to be created", "pod", klog.KObj(pod), "podUID", pod.UID)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is V(4) too high? In most cases it will not be enabled and if this introduces some regression, it will be impossible to troubleshoot

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V(3) preferred?

@SergeyKanzhelev
Copy link
Member

Can we get a unit test for this? :)

The fact that the existing unit test is failing is worrisome.

@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Waiting on Author in SIG Node PR Triage May 12, 2021
@adisky
Copy link
Contributor

adisky commented May 20, 2021

looks like flake and a PR is there to fix #102086
/test pull-kubernetes-unit

@ehashman
Copy link
Member

/close

@k8s-ci-robot
Copy link
Contributor

@ehashman: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SIG Node PR Triage automation moved this from Waiting on Author to Done May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev left review comments

@krmayankk krmayankk Awaiting requested review from krmayankk

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees
No one assigned
Labels
area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Node PR Triage
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rphillips @k8s-ci-robot @ehashman @SergeyKanzhelev @adisky