-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup translations and fix update-translations.sh #102072
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @atiratree! |
Hi @atiratree. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/check-cla |
/assign @soltysh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atiratree could you please squash your patches so would be easier to review it?
@dougsland I have squashed all the generated changes to one commit, but kept the features commits for better clarity |
- update template.pot - reformat .po files - regenerate .mo files - regenarate and mark obsolete translations - remove obsolete default/english translations
rebased |
/ok-to-test |
/priority backlog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atiratree, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'm a bit confused about this pr, if an English language is not translated and it needs to be translated, it won't be added to the corresponding language's The result now is that the @atiratree |
@hwdef We are only storing the translated parts. The rest will be defaulted to english. If you want to add new translations. you need to first generate the Nevertheless, the translations and the script are not really well maintained. So, if you want to help with this effort , I suggest to visit sig-cli call and ask there first. Useful resource is also the |
Thank you! I wil try what you said. |
yes, although for some finer tuning, you may need to consult the gettext CLI tools/documentation or do it manually |
Thank you very much! |
What type of PR is this?
/kind cleanup
/sig cli
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
update-translations.sh
script to fix old/new msgids. I am not sure if we should include this logic with already present-g
option or have it as a new standalone option-k
.#~
). It is like that, because it is nice to run this script automatically, but to keep the old unused translations in the file. So the translators can easily copy changed translation when for example only one letter changed. The obsoleted translations need to be removed manually, which is easy since they are at the end of the file.update-translations.sh
and the rest are various generated changesDoes this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: