Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating prometheus/common to v0.25.0 from v0.10.0 #102144

Closed
wants to merge 1 commit into from
Closed

updating prometheus/common to v0.25.0 from v0.10.0 #102144

wants to merge 1 commit into from

Conversation

RinkiyaKeDad
Copy link
Member

Signed-off-by: RinkiyaKeDad arshsharma461@gmail.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates github.com/prometheus/common from v0.10.0 to v0.25.0.

Special notes for your reviewer:

Final output from hack/update-vendor.sh had this as the last line:

+++ [0519 21:03:17] NOTE: don't forget to handle vendor/* files that were added or removed

Does something needs to be done in regards to this?

Does this PR introduce a user-facing change?

NONE

Link to the relevant slack discussion.

/assign @dims

@RinkiyaKeDad
updated version
c7f5b11 
Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 19, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @RinkiyaKeDad. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RinkiyaKeDad
To complete the pull request process, please assign liggitt after the PR has been reviewed.
You can assign the PR to them by writing /assign @liggitt in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 19, 2021
@k8s-ci-robot k8s-ci-robot requested review from andrewsykim, aojea and a team May 19, 2021 15:37
@dims
Copy link
Member

dims commented May 19, 2021

/ok-to-test
/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 19, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 19, 2021
@dims
Copy link
Member

dims commented May 19, 2021

/assign @dashpole @liggitt

@RinkiyaKeDad
Copy link
Member Author

The check-dependency-stats job ran automatically. Yaaaay!

liggitt
liggitt reviewed May 19, 2021
View reviewed changes
go.mod
Comment on lines +174 to +177
github.com/Shopify/sarama => github.com/Shopify/sarama v1.19.0
github.com/Shopify/toxiproxy => github.com/Shopify/toxiproxy v2.1.4+incompatible
github.com/VividCortex/gohistogram => github.com/VividCortex/gohistogram v1.0.0
github.com/afex/hystrix-go => github.com/afex/hystrix-go v0.0.0-20180502004556-fa1af6a1f4f5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what brought all of these in?

liggitt
liggitt reviewed May 19, 2021
View reviewed changes
go.mod
github.com/asaskevich/govalidator => github.com/asaskevich/govalidator v0.0.0-20190424111038-f61b66f89f4a
github.com/auth0/go-jwt-middleware => github.com/auth0/go-jwt-middleware v0.0.0-20170425171159-5493cabe49f7
github.com/aws/aws-lambda-go => github.com/aws/aws-lambda-go v1.13.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what brought in new cloud provider libs?

liggitt
liggitt reviewed May 19, 2021
View reviewed changes
go.mod
github.com/aws/aws-sdk-go => github.com/aws/aws-sdk-go v1.35.24
github.com/aws/aws-sdk-go-v2 => github.com/aws/aws-sdk-go-v2 v0.18.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what brought in new cloud provider libs?

liggitt
liggitt reviewed May 19, 2021
View reviewed changes
go.mod
github.com/ianlancetaylor/demangle => github.com/ianlancetaylor/demangle v0.0.0-20181102032728-5e5cf60278f6
github.com/imdario/mergo => github.com/imdario/mergo v0.3.5
github.com/inconshreveable/mousetrap => github.com/inconshreveable/mousetrap v1.0.0
github.com/influxdata/influxdb1-client => github.com/influxdata/influxdb1-client v0.0.0-20191209144304-8bf82d3c094d
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what brought in a db client dependency?

@liggitt
Copy link
Member

liggitt commented May 19, 2021

This looks to have brought in a startling number of additional dependencies, and is the sort of thing we want to catch/prevent with our dependency checking.

Use go mod why or go mod graph to determine what is causing these new dependencies. An issue should be opened for the upstream that added them to request they be dropped/isolated so downstream consumers (like us) don't have to be exposed to them.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2021
@k8s-ci-robot
Copy link
Contributor

@RinkiyaKeDad: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-unit c7f5b11 link /test pull-kubernetes-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dims
Copy link
Member

dims commented May 19, 2021

@liggitt found the source of the boatload of deps - prometheus/common#255

@k8s-ci-robot
Copy link
Contributor

@RinkiyaKeDad: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

2 similar comments
@k8s-ci-robot
Copy link
Contributor

@RinkiyaKeDad: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@RinkiyaKeDad: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liggitt
Copy link
Member

liggitt commented May 19, 2021

found the source of the boatload of deps - prometheus/common#255

that's exceptionally unfortunate, especially since the library doesn't seem concerned about the issue

@k8s-ci-robot
Copy link
Contributor

@RinkiyaKeDad: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RinkiyaKeDad RinkiyaKeDad mentioned this pull request May 28, 2021
Closed
@dims
Copy link
Member

dims commented May 28, 2021

@RinkiyaKeDad given that promethus/common and go-kit folks will take their own time given comments in prometheus/common#255 and prometheus/common#302

Let's not waste our time. If it happens we can update then.

@RinkiyaKeDad
Copy link
Member Author

Closing till we figure out a way to avoid the extra dependencies which come with github.com/go-kit/kit

@dims dims mentioned this pull request Jun 3, 2021
Merged
@peterbourgon
Copy link

peterbourgon commented Jun 3, 2021 •
edited

The indirect dependencies appear in your go.mod, but unless you use them, they aren't brought into the build, and they don't make it into any artifacts. I completely understand the desire to keep dependency graphs small, but there is limited effect on the module, and zero effect on any artifacts. And for a project like this one, that particular ship sailed a long time ago — the marginal cost of the additional deps brought in by Go kit is practically zero.

@dims
Copy link
Member

dims commented Jun 3, 2021

@peterbourgon Ack and thanks! we are still trying and it's slowly getting better with every release.

@pacoxu pacoxu mentioned this pull request Jun 16, 2021
Merged
rnaveiras added a commit to rnaveiras/postgres_exporter that referenced this pull request Feb 18, 2022
@rnaveiras
Replace go-kit/kit with go-kit/log
1eddc2c 
github.com/go-kit/kit is only being used for the log packages and brings
in a lot of dependencies as compared to github.com/go-kit/log. This
would help determine how useful switching would be.

For reference see kubernetes/kubernetes#102144 and prometheus/common#255 (comment)
@rnaveiras rnaveiras mentioned this pull request Feb 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@aojea aojea Awaiting requested review from aojea

Assignees

@dims dims

@liggitt liggitt

@dashpole dashpole

Labels
area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@RinkiyaKeDad @k8s-ci-robot @dims @liggitt @peterbourgon @dashpole