Update pd csi driver images to use v1 images (CSINode, CSIDriver, etc) #102212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
area/test
sig/testing
|
I noticed the controller gce pd driver was at v1.0.1 and the node was at v0.7.0, any reason for the skew or is that just an oversight? At any rate these manifests will soon go away as we are going to be installing the driver by default in kube-up. |
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
|
/lgtm |
k8s-ci-robot
added
the
lgtm
I think it was just oversight |
k8s-ci-robot
added
the
approved
msau42
reviewed
May 21, 2021
| volumeMounts: | ||
| - name: socket-dir | ||
| mountPath: /csi | ||
| - name: gce-pd-driver | ||
| image: gcr.io/gke-release/gcp-compute-persistent-disk-csi-driver:v1.0.1-gke.0 | ||
| image: gcr.io/gke-release/gcp-compute-persistent-disk-csi-driver:v1.2.1-gke.0 |
There was a problem hiding this comment.
We haven't fixed the k8s image building issue yet?
There was a problem hiding this comment.
Thanks, I just copied this from stable-master on the upstream driver. But that's out of date, we've moved to v1.2.2-gke.2 on GKE already.
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
size/L
|
I missed the leader election rbac.
…On Fri, May 21, 2021 at 1:25 PM Kubernetes Prow Robot < ***@***.***> wrote:
@mattcary <https://github.com/mattcary>: The following tests *failed*,
say /retest to rerun all failed tests:
Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-storage-slow 4b5e027
<4b5e027>
link
<https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/102212/pull-kubernetes-e2e-gce-storage-slow/1395797744899067904/> /test
pull-kubernetes-e2e-gce-storage-slow
pull-kubernetes-e2e-gce-storage-snapshot 4b5e027
<4b5e027>
link
<https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/102212/pull-kubernetes-e2e-gce-storage-snapshot/1395797745737928704/> /test
pull-kubernetes-e2e-gce-storage-snapshot
pull-kubernetes-e2e-gce-csi-serial 4b5e027
<4b5e027>
link
<https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/102212/pull-kubernetes-e2e-gce-csi-serial/1395797746576789504/> /test
pull-kubernetes-e2e-gce-csi-serial
Full PR test history
<https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=102212>.
Your PR dashboard
<https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Amattcary>.
Please help us cut down on flakes by linking to
<https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#102212 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIJCBAA5AFXXKNS3P5BTLQLTO26TFANCNFSM45JTBY5Q>
.
|
|
Darn it, 1.2.2 is still in staging. Switching back to 1.2.1 until I figure
out when the promotion will happen.
…On Fri, May 21, 2021 at 4:14 PM Kubernetes Prow Robot < ***@***.***> wrote:
@mattcary <https://github.com/mattcary>: The following tests *failed*,
say /retest to rerun all failed tests:
Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-storage-snapshot b36cece
<b36cece>
link
<https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/102212/pull-kubernetes-e2e-gce-storage-snapshot/1395840144149319680/> /test
pull-kubernetes-e2e-gce-storage-snapshot
pull-kubernetes-e2e-gce-csi-serial b36cece
<b36cece>
link
<https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/102212/pull-kubernetes-e2e-gce-csi-serial/1395840144988180480/> /test
pull-kubernetes-e2e-gce-csi-serial
Full PR test history
<https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=102212>.
Your PR dashboard
<https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Amattcary>.
Please help us cut down on flakes by linking to
<https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#102212 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIJCBAA4XTKX5L7CRUKAPXTTO3SMHANCNFSM45JTBY5Q>
.
|
|
Oh, wait, we should be using the upstream cloud build jobs now.
…On Fri, May 21, 2021 at 4:56 PM Matthew Cary ***@***.***> wrote:
Darn it, 1.2.2 is still in staging. Switching back to 1.2.1 until I figure
out when the promotion will happen.
On Fri, May 21, 2021 at 4:14 PM Kubernetes Prow Robot <
***@***.***> wrote:
> @mattcary <https://github.com/mattcary>: The following tests *failed*,
> say /retest to rerun all failed tests:
> Test name Commit Details Rerun command
> pull-kubernetes-e2e-gce-storage-snapshot b36cece
> <b36cece>
> link
> <https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/102212/pull-kubernetes-e2e-gce-storage-snapshot/1395840144149319680/> /test
> pull-kubernetes-e2e-gce-storage-snapshot
> pull-kubernetes-e2e-gce-csi-serial b36cece
> <b36cece>
> link
> <https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/102212/pull-kubernetes-e2e-gce-csi-serial/1395840144988180480/> /test
> pull-kubernetes-e2e-gce-csi-serial
>
> Full PR test history
> <https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=102212>.
> Your PR dashboard
> <https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Amattcary>.
> Please help us cut down on flakes by linking to
> <https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests>
> an open issue
> <https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open>
> when you hit one in your PR.
>
> Instructions for interacting with me using PR comments are available here
> <https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
> you have questions or suggestions related to my behavior, please file an
> issue against the kubernetes/test-infra
> <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
> repository. I understand the commands that are listed here
> <https://go.k8s.io/bot-commands>.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#102212 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AIJCBAA4XTKX5L7CRUKAPXTTO3SMHANCNFSM45JTBY5Q>
> .
>
|
mattcary
force-pushed
the
csidriver
branch
2 times, most recently
from
ae6c6c8
to
cb3d42a
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattcary, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mattcary
force-pushed
the
csidriver
branch
2 times, most recently
from
9ed3cd6
to
df2b726
Compare
|
/test pull-kubernetes-e2e-gce-csi-serial |
Change-Id: I51ddf0014dcfe476495e324ee33aa658e7199477
|
Looks like a metricsgrabber flake /test pull-kubernetes-e2e-gce-ubuntu-containerd |
msau42
reviewed
May 26, 2021
| SigStorageRegistry: "k8s.gcr.io/sig-storage", | ||
| PrivateRegistry: "gcr.io/k8s-authenticated-test", | ||
| SampleRegistry: "gcr.io/google-samples", | ||
| GcrReleaseRegistry: "gcr.io/gke-release", |
There was a problem hiding this comment.
I think we can actually remove this one too. But let's leave it to a separate PR
There was a problem hiding this comment.
+1 thanks. I meant to ask if I was doing this manifest stuff correctly, I don't understand how it works, I was just adding stuff until the build worked.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind bug
/kind failing-test
/sig storage
Fixes #102077
/assign @msau42