Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor cmd/kubeadm/app/preflight/checks_test.go #102546

Merged
merged 1 commit into from
Jun 16, 2021
Merged

refactor cmd/kubeadm/app/preflight/checks_test.go #102546

merged 1 commit into from
Jun 16, 2021

Conversation

lunhuijie
Copy link
Contributor

@lunhuijie lunhuijie commented Jun 3, 2021 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Add UTs

Which issue(s) this PR fixes:

Fixes #
Fixes kubernetes/kubeadm#2251

Special notes for your reviewer:

Does this PR introduce a user-facing change?

"NONE"

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 3, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @lunhuijie. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 3, 2021
@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 3, 2021
SataQiu
SataQiu reviewed Jun 3, 2021
View reviewed changes
cmd/kubeadm/app/preflight/checks_test.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/preflight/checks_test.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/preflight/checks_test.go Outdated Show resolved Hide resolved
@changshuchao
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 3, 2021
@lunhuijie lunhuijie force-pushed the refactorCheckTest branch 3 times, most recently from 1b8dd64 to 4522631 Compare June 3, 2021 07:52
@lunhuijie lunhuijie changed the title refactor cmd/kubeadm/app/preflight/checks_test.go (Step 1: Add UTs for checks what belongs to file's checking) refactor cmd/kubeadm/app/preflight/checks_test.go (Step 1, 2) Jun 3, 2021
@lunhuijie lunhuijie force-pushed the refactorCheckTest branch 3 times, most recently from 405b19c to 327aae4 Compare June 4, 2021 02:53
@lunhuijie
Copy link
Contributor Author

I first added the test cases for the unit test, and I haven’t deleted TestRunInitNodeChecks TestRunJoinNodeChecks yet for a better review. And I plan to push a new PR to delete TestRunInitNodeChecks &TestRunJoinNodeChecks after these push without any problem. @neolit123

@lunhuijie
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@lunhuijie lunhuijie requested a review from SataQiu June 5, 2021 05:59
cndoit18
cndoit18 reviewed Jun 6, 2021
View reviewed changes
cmd/kubeadm/app/preflight/checks_test.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/preflight/checks_test.go Outdated Show resolved Hide resolved
@neolit123
Copy link
Member

neolit123 commented Jun 7, 2021 via email

neolit123
neolit123 reviewed Jun 10, 2021
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is getting close to ready.
added some more comments.

@lunhuijie lunhuijie force-pushed the refactorCheckTest branch 2 times, most recently from 90920a9 to 70b3628 Compare June 10, 2021 04:11
@neolit123
Copy link
Member

@lunhuijie
please squash the commits to one and we can merge this change.

@lunhuijie lunhuijie force-pushed the refactorCheckTest branch 3 times, most recently from b9909ca to fd167f7 Compare June 15, 2021 01:27
@lunhuijie lunhuijie changed the title refactor cmd/kubeadm/app/preflight/checks_test.go (Step 1, 2) refactor cmd/kubeadm/app/preflight/checks_test.go Jun 15, 2021
@lunhuijie
Copy link
Contributor Author

/test pull-kubernetes-unit

@lunhuijie
refactor cmd/kubeadm/app/preflight/checks_test.go()
84112d3 
Signed-off-by: 刁浩 10284789 <diao.hao@zte.com.cn>
neolit123
neolit123 reviewed Jun 16, 2021
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lunhuijie, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 3c1db41 into kubernetes:master Jun 16, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 16, 2021
@lunhuijie lunhuijie mentioned this pull request Jun 21, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@cndoit18 cndoit18 cndoit18 left review comments

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

refactor cmd/kubeadm/app/preflight/checks_test.go
6 participants
@lunhuijie @k8s-ci-robot @changshuchao @neolit123 @cndoit18 @SataQiu