images: Removes OS Version workaround for manifest list images

[claudiubelu]

What type of PR is this?

/kind cleanup

/sig testing
/sig windows

What this PR does / why we need it:

For manifest lists containing Windows images, it is important to also have the os.version annotation set, as it is needed by the Windows nodes, so they can pull the appropriate image from the list.

Previously, the docker manifest CLI did not have the capability to set it, so, we had to set it outselves in the manifest list's image JSON file. This is no longer necessary since docker 20.10.0, which includes docker manifest annotate --os-version.

The docker installed in the image gcr.io/k8s-testimages/gcb-docker-gcloud:v20210622-762366a satisfies this version requirement.

Docker CLI PR: docker/cli#2578

Pause image logs: https://paste.ubuntu.com/p/dS9tKWqYsw/

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

@claudiubelu: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dims]

@BenTheElder @cblecker Any concern over the new minimum docker version dependency?

[BenTheElder]

I think this is reasonable, most developers are not building the test images anyhow, I'm not sure exactly where we should draw the line for the core images which lots of people are building all the time for development in addition to downstream distros, but for test images mostly built by CI this seems fine without getting too into the weeds.

I think there's a discussion to be had somewhere about what docker version is reasonable to require, along with the buildx issue

[claudiubelu]

I think this is reasonable, most developers are not building the test images anyhow, I'm not sure exactly where we should draw the line for the core images which lots of people are building all the time for development in addition to downstream distros, but for test images mostly built by CI this seems fine without getting too into the weeds.

I think there's a discussion to be had somewhere about what docker version is reasonable to require, along with the buildx issue

FWIW, the image gcr.io/k8s-testimages/gcb-docker-gcloud:v20210622-762366a can also be used to build those images, that's how I did it, if you check the pause image logs. The gcb-docker-gcloud image can also be individually built if needed (I had to build that for myself some time ago). The image will contain the appropriate docker CLI version for this.

[marosset]

/milestone v1.23

[spiffxp]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: claudiubelu, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• build/pause/OWNERS [spiffxp]
• test/images/OWNERS [spiffxp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment