Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sync reconstructed volume from desired state of world for volumemanager #103181

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Add sync reconstructed volume from desired state of world for volumemanager #103181

merged 1 commit into from
Jul 19, 2021

Conversation

249043822
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #103143

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 25, 2021
@249043822
Copy link
Member Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 25, 2021
@249043822
Copy link
Member Author

/assign @jingxu97

@249043822
Copy link
Member Author

/test pull-kubernetes-e2e-gce-storage-slow

@ehashman ehashman added this to Triage in SIG Node PR Triage Jun 25, 2021
@ehashman
Copy link
Member

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Jun 25, 2021
@ehashman
Copy link
Member

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 25, 2021
@ehashman ehashman moved this from Triage to Needs Reviewer in SIG Node PR Triage Jun 25, 2021
@249043822
Copy link
Member Author

/ping @jingxu97

@249043822
Copy link
Member Author

/assign @msau42

jingxu97
jingxu97 reviewed Jul 12, 2021
View reviewed changes
pkg/kubelet/volumemanager/cache/actual_state_of_world.go Outdated
@@ -171,6 +171,10 @@ type ActualStateOfWorld interface {
// to the node. This list can be used to determine volumes that are either in-use
// or have a mount/unmount operation pending.
GetAttachedVolumes() []AttachedVolume

// SyncReconstructedVolume check the volume.outerVolumeSpecName in asw with
// the parameter outerVolumeSpecName from dsw , if dis-match, update this field from desired state information
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just small nit, how about

// SyncReconstructedVolume check the volume.outerVolumeSpecName in asw with
// the one populated from dsw , if they do not match, update this field from the value from dsw.

jingxu97
jingxu97 reviewed Jul 12, 2021
View reviewed changes
pkg/kubelet/volumemanager/populator/desired_state_of_world_populator_test.go Outdated
},
},
}
pod := createPodWithVolume("dswp-test-pod", "dswp-test-volume-name", "file-bound", containers)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about make "dswp-test-volume-name" as a variable (outername) to make it easy to check

@jingxu97
Copy link
Contributor

@249043822 thanks a lot for the PR. Sorry for the delay.
I think the fix looks good, just a couple of small comments.

@249043822
Copy link
Member Author

/test pull-kubernetes-e2e-gce-storage-slow

@249043822
Copy link
Member Author

@jingxu97 Thanks for your review, I have fixed the nits and pushed again.

@249043822
Copy link
Member Author

@jingxu97 nits fixed

@jingxu97
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2021
@jingxu97 jingxu97 added this to the v1.22 milestone Jul 13, 2021
@ehashman ehashman moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Jul 13, 2021
@ehashman
Copy link
Member

@jingxu97 needs SIG Storage approval

@ehashman
Copy link
Member

/assign @jingxu97

@ehashman ehashman moved this from Needs Approver to Done in SIG Node PR Triage Jul 13, 2021
@jingxu97
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 249043822, jingxu97

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6aa160f into kubernetes:master Jul 19, 2021
@msau42 msau42 mentioned this pull request Jul 21, 2021
Closed
@heartlock
Copy link
Contributor

heartlock commented Mar 23, 2022 •
edited

@249043822 Are there any plans to cherry pick the PR into 1.21(and maybe 1.20,1.19)?

@249043822 249043822 mentioned this pull request Mar 26, 2022
Closed
@249043822
Copy link
Member Author

@heartlock I have cherry-picked into 1.21(#109046), but I'm not sure whether 1.20 or before branches still active to accepted changes

@carlory carlory mentioned this pull request Apr 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 jingxu97 left review comments

@davidz627 davidz627 Awaiting requested review from davidz627

@gnufied gnufied Awaiting requested review from gnufied

Assignees

@jingxu97 jingxu97

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.22
6 participants
@249043822 @ehashman @jingxu97 @k8s-ci-robot @heartlock @msau42