Fix delete nil pointer panic

[astraw99]

What type of PR is this?

/kind bug

What this PR does / why we need it:

check if options.GracePeriodSeconds is nil to avoid delete panic

Which issue(s) this PR fixes:

Fixes #103228

Special notes for your reviewer:

Use apiserver extension(APIService) strategy, impl this function below will lead to panic:

// just impl this method and return true, then will lead to delete resource panic
func (s Strategy) CheckGracefulDelete(ctx context.Context, obj runtime.Object, options *metav1.DeleteOptions) bool {
	return true
}

Does this PR introduce a user-facing change?

NONE

SIG labels

• sig apiserver
• sig api-machinery

[k8s-ci-robot]

Hi @astraw99. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yangjunmyfm192085]

Maybe you need rebase?

[lauchokyip]

/ok-to-test

[astraw99]

/cc @liggitt @wojtek-t @yangjunmyfm192085 PTAL, thx.

[liggitt]

This looks reasonable, thanks. Please squash to a single commit before merge.

[astraw99]

/cc @liggitt Have squashed to 1 commit, thanks.

[dims]

do we need a test of some sort @liggitt ?

[liggitt]

do we need a test of some sort @liggitt ?

a nil check here is reasonable by inspection... the dereference on the next line ensures this is only improving errors that were already existing.

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astraw99, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/apiserver/OWNERS [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yangjunmyfm192085]

/retest

[caesarxuchao]

/triage accepted