Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop end of sunrpc port range to avoid port conflicts. #103376

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Drop end of sunrpc port range to avoid port conflicts. #103376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions cluster/gce/gci/node.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,13 @@ write_files:
[Install]
WantedBy=multi-user.target

- path: /etc/modprobe.d/sunrpc.conf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is always present, correct? Any chance there is a configuration without this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/etc/modprobe.d always exists in the COS and ubuntu images supported (as I understand) by gci. sunrpc.conf does not currently exist anywhere I've looked, so we're creating it with this PR.

permissions: 0644
owner: root
# The GKE metadata server uses ports 987-989, so the sunrpc range should be restricted to be below.
content: |
options sunrpc max_resvport=986
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please leave a comment for future on why it is 986.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


runcmd:
- systemctl daemon-reload
- systemctl enable kube-node-installation.service
Expand Down