Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/e2e/network: add test for Service internalTrafficPolicy #103409

Merged
merged 4 commits into from
Jul 7, 2021
Merged

test/e2e/network: add test for Service internalTrafficPolicy #103409

merged 4 commits into from
Jul 7, 2021

Conversation

andrewsykim
Copy link
Member

Signed-off-by: Andrew Sy Kim kim.andrewsy@gmail.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds an e2e test for internalTrafficPolicy field.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 1, 2021
@andrewsykim andrewsykim force-pushed the service-internal-traffic-policy-e2e branch from 62f00df to 03db130 Compare July 1, 2021 16:52
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 1, 2021
@k8s-ci-robot k8s-ci-robot added area/test sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 1, 2021
@andrewsykim andrewsykim force-pushed the service-internal-traffic-policy-e2e branch from 03db130 to 8a1cd1e Compare July 1, 2021 17:05
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andrewsykim andrewsykim force-pushed the service-internal-traffic-policy-e2e branch from 8a1cd1e to 98c069d Compare July 1, 2021 17:12
@andrewsykim
Copy link
Member Author

/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 1, 2021
@andrewsykim andrewsykim changed the title [WIP] test/e2e/network: add test for Service internalTrafficPolicy test/e2e/network: add test for Service internalTrafficPolicy Jul 1, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2021
@andrewsykim
Copy link
Member Author

/assign @thockin @robscott @aojea @maplain

@aojea
Copy link
Member

aojea commented Jul 2, 2021

Host network better separate , per example, openshift imposes limitations on host network pods for security reasons, this way they people can filter then

@andrewsykim andrewsykim force-pushed the service-internal-traffic-policy-e2e branch 2 times, most recently from d81a394 to 9fd7ef2 Compare July 4, 2021 04:21
@andrewsykim
Copy link
Member Author

/retest

@andrewsykim
Copy link
Member Author

@aojea updated with new test cases using host network pods, PTAL

@andrewsykim andrewsykim mentioned this pull request Jul 5, 2021
Merged
@andrewsykim
Copy link
Member Author

/retest

@andrewsykim
Copy link
Member Author

Oddly the network policy tests are running the new e2e tests in this PR despite the Feature tag being used. Their failing of course because the feature is not enabled yet.

@aojea
Copy link
Member

aojea commented Jul 5, 2021

Oddly the network policy tests are running the new e2e tests in this PR despite the Feature tag being used. Their failing of course because the feature is not enabled yet.

yep, the policy job run all sig-network tests, I asked to do this because twe can detect if the network policy tests "behave" and play well running in parallel with other tests, and doesn't block other traffic ... I need to find out if ginkgo can suppress all new features except the NetworkPlicy ones

@andrewsykim
Copy link
Member Author

Sounds good, in the meantime I think we can just merge this after #103462

@aojea
Copy link
Member

aojea commented Jul 6, 2021

Sounds good, in the meantime I think we can just merge this after #103462

/lgtm
/hold
until #103462 merges so the pull-kubernetes-e2e-ubuntu-gce-network-policies — Job run the tests and validates the code

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 6, 2021
@andrewsykim
test/e2e/network: add Service internalTrafficPolicy test pod to pod
f6bc5d0 
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
@andrewsykim
test/e2e/network: add Service internalTrafficPolicy test pod (w/ host…
025c95a 
… network) -> pod

Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
@andrewsykim
test/e2e/network: add Service internalTrafficPolicy test for pod -> p…
9977ea3 
…od (w/ host network)

Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
@andrewsykim
test/e2e/network: add Service internalTrafficPolicy test for pod (w/ …
04d59ff 
…host network) -> pod (w/ host network)

Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
@andrewsykim andrewsykim force-pushed the service-internal-traffic-policy-e2e branch from 9fd7ef2 to 04d59ff Compare July 6, 2021 13:22
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2021
@andrewsykim
Copy link
Member Author

andrewsykim commented Jul 6, 2021 •
edited
Loading

NetworkPolicy failures might be legit, but will re-run one more time to be sure https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/103409/pull-kubernetes-e2e-ubuntu-gce-network-policies/1412401677541052416

/retest

@aojea
Copy link
Member

aojea commented Jul 6, 2021

NetworkPolicy failures might be legit, but will re-run one more time to be sure https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/103409/pull-kubernetes-e2e-ubuntu-gce-network-policies/1412401677541052416

/retest

/lgtm

unhold when you are happy Andrew, the test added here are passing 👍

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2021
@andrewsykim
Copy link
Member Author

/retest

@andrewsykim
Copy link
Member Author

/hold cancel
/retest

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2021
@aojea
Copy link
Member

aojea commented Jul 7, 2021

/test pull-kubernetes-integration

k8s.io/kubernetes/test/integration/auth: TestDiscoveryUpgradeBootstrapping expand_more7m38s | k8s.io/kubernetes/test/integration/auth: TestDiscoveryUpgradeBootstrapping expand_more | 7m38s
-- | -- | --
k8s.io/kubernetes/test/integration/auth: TestDiscoveryUpgradeBootstrapping expand_more | 7m38s
k8s.io/kubernetes/test/integration/client: TestDynamicClientWatch expand_more2m49s | k8s.io/kubernetes/test/integration/client: TestDynamicClientWatch expand_more | 2m49s
k8s.io/kubernetes/test/integration/client: TestDynamicClientWatch expand_more | 2m49s
k8s.io/kubernetes/test/integration/client: TestExecPluginViaClient expand_more6m36s | k8s.io/kubernetes/test/integration/client: TestExecPluginViaClient expand_more | 6m36s
k8s.io/kubernetes/test/integration/client: TestExecPluginViaClient expand_more | 6m36s
k8s.io/kubernetes/test/integration/controlplane: TestRun expand_more2m43s | k8s.io/kubernetes/test/integration/controlplane: TestRun expand_more | 2m43s
k8s.io/kubernetes/test/integration/controlplane: TestRun expand_more | 2m43s
k8s.io/kubernetes/test/integration/controlplane: TestLivezAndReadyz expand_more | k8s.io/kubernetes/test/integration/controlplane: TestLivezAndReadyz expand_more
k8s.io/kubernetes/test/integration/controlplane: TestLivezAndReadyz expand_more

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 7, 2021 •
edited
Loading

@andrewsykim: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-ubuntu-gce-network-policies 04d59ff link /test pull-kubernetes-e2e-ubuntu-gce-network-policies

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit b289fbb into kubernetes:master Jul 7, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 7, 2021
@andrewsykim andrewsykim mentioned this pull request Sep 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea aojea left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

Assignees

@robscott robscott

@maplain maplain

@thockin thockin

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@andrewsykim @k8s-ci-robot @aojea @robscott @maplain @thockin