-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop hack/verify-staticcheck.sh in favor of enablingstaticcheck
plugin in hack/verify-golangci-lint.sh
#103721
Comments
/sig architecture |
/assign @hlee95 |
@nikhita: GitHub didn't allow me to assign the following users: hlee95. Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign |
OSD very fast to pickup 🥇 |
/area code-organization |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
/triage accepted |
Step 1: Enable
staticcheck
plugin in verify-golangci-lint.shStep 2: run
hack/verify-golangci-lint.sh
and see the failures. As of opening this bug the failures are as follows:Step 3: fix each instance, either by making a minimal code change or adding a
//nolint:staticcheck
(for example to ignore the deprecation warnings, see https://golangci-lint.run/usage/false-positives/)Step 4: remove
hack/verify-staticcheck.sh
and cleanuphack/tools/go.mod
to remove references tohonnef.co/go/tools/cmd/staticcheck
which is used in that scriptThe text was updated successfully, but these errors were encountered: