Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate cmd/proxy/app and pkg/proxy/meta_proxier to structured logging #104928

Merged
merged 10 commits into from Sep 15, 2021
Merged

Migrate cmd/proxy/app and pkg/proxy/meta_proxier to structured logging #104928

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e2df90d
migrate log
jyz0309 Sep 11, 2021
fdf7ecc
remove useless change
jyz0309 Sep 11, 2021
4ab6088
use nil to instead err
jyz0309 Sep 12, 2021
8542736
fix comment
jyz0309 Sep 13, 2021
4d5d649
remove useless change
jyz0309 Sep 13, 2021
028cf7b
resolve conflict
jyz0309 Sep 14, 2021
b05a512
resolve conflict
jyz0309 Sep 14, 2021
ab8915c
fix comment
jyz0309 Sep 14, 2021
0730eaa
fix comment
jyz0309 Sep 14, 2021
3aabbff
fix comment
jyz0309 Sep 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/kube-proxy/app/server_others.go
View file
Open in desktop
Expand Up @@ -203,9 +203,9 @@ func newProxyServer(
}
}
if dualStack {
klog.V(0).Infof("kube-proxy running in dual-stack mode, %s-primary", iptInterface.Protocol())
klog.V(0).InfoS("kube-proxy running in dual-stack mode", "ipFamily", iptInterface.Protocol())
} else {
klog.V(0).Infof("kube-proxy running in single-stack %s mode", iptInterface.Protocol())
klog.V(0).InfoS("kube-proxy running in single-stack mode", "ipFamily", iptInterface.Protocol())
}

if proxyMode == proxyModeIPTables {
Expand Down
6 changes: 3 additions & 3 deletions pkg/proxy/metaproxier/meta_proxier.go
View file
Open in desktop
Expand Up @@ -152,7 +152,7 @@ func (proxier *metaProxier) OnEndpointSliceAdd(endpointSlice *discovery.Endpoint
case discovery.AddressTypeIPv6:
proxier.ipv6Proxier.OnEndpointSliceAdd(endpointSlice)
default:
klog.V(4).Infof("EndpointSlice address type not supported by kube-proxy: %s", endpointSlice.AddressType)
klog.ErrorS(nil, "EndpointSlice address type not supported", "type", endpointSlice.AddressType)
jyz0309 marked this conversation as resolved.
Show resolved Hide resolved
}
}

Expand All @@ -165,7 +165,7 @@ func (proxier *metaProxier) OnEndpointSliceUpdate(oldEndpointSlice, newEndpointS
case discovery.AddressTypeIPv6:
proxier.ipv6Proxier.OnEndpointSliceUpdate(oldEndpointSlice, newEndpointSlice)
default:
klog.V(4).Infof("EndpointSlice address type not supported by kube-proxy: %s", newEndpointSlice.AddressType)
klog.ErrorS(nil, "EndpointSlice address type not supported", "type", newEndpointSlice.AddressType)
}
}

Expand All @@ -178,7 +178,7 @@ func (proxier *metaProxier) OnEndpointSliceDelete(endpointSlice *discovery.Endpo
case discovery.AddressTypeIPv6:
proxier.ipv6Proxier.OnEndpointSliceDelete(endpointSlice)
default:
klog.V(4).Infof("EndpointSlice address type not supported by kube-proxy: %s", endpointSlice.AddressType)
klog.ErrorS(nil, "EndpointSlice address type not supported", "type", endpointSlice.AddressType)
}
}

Expand Down