-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pin-dependency.sh: enhance forking of a dependency #104995
pin-dependency.sh: enhance forking of a dependency #104995
Conversation
@pohly: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @liggitt |
This addresses a problem that occurred when trying the following replacement: hack/pin-dependency.sh k8s.io/klog/v2=github.com/pohly/klog/v2 flush-log-sink That itself worked, but update-vendor.sh then failed: === tidying go.mod/go.sum in staging/src/k8s.io/code-generator/examples go: k8s.io/apimachinery@v0.0.0 requires k8s.io/klog/v2@v2.4.1-0.20210909144920-0b91caa8c854: invalid version: unknown revision 0b91caa8c854 go: k8s.io/apimachinery@v0.0.0 requires k8s.io/klog/v2@v2.4.1-0.20210909144920-0b91caa8c854: invalid version: unknown revision 0b91caa8c854
d972bc9
to
de47d00
Compare
/sig architecture |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This addresses a problem that occurred when trying the following replacement:
That itself worked, but update-vendor.sh then failed:
Special notes for your reviewer:
Not sure why that problem surfaced now and not when I originally added the support for forking a dependency.
Does this PR introduce a user-facing change?