-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore register already exist error for metrics #105223
Conversation
@pacoxu: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@pacoxu: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pacoxu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/sig instrumentation A simple way to reproduce it using
|
@pacoxu: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/remove-sig api-machinery |
Is this ready for review? |
This can fix the dup registed error, but it can not fix the failure with “-count=10”(the metrics can not be reset during the unit test) |
See #105809 |
/kind bug
xref #104940
The problem is similar to prometheus/client_golang#716 (comment).
I tried to fix 104940 by ignoring AlreadyRegisteredError in the implementation of MustRegister. (I am inspired by https://github.com/weaveworks/promrus/pull/9/files)
kubernetes/vendor/github.com/prometheus/client_golang/prometheus/registry.go
Lines 400 to 406 in 005dfcd