etcd-storage-test: mark node ready to save it for 5min from cloud provider deletion

[sttts]

The test creates a node1 node object without any condition. Some cloud providers delete nodes without matching VMs. Hence, the etcd storage test races with the node controller.

Compare https://bugzilla.redhat.com/show_bug.cgi?id=2008926.

/kind bug
/kind flake

NONE

[k8s-ci-robot]

@sttts: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sttts]

/assign @aojea

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/integration/etcd/OWNERS [sttts]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[elmiko]

makes sense to me, +1

[aojea]

/lgtm

Since the description mentions that the function is exported on purpose it seems fair to use it outside of integration,

kubernetes/test/integration/etcd/data.go

Lines 34 to 38 in ab86b9c

	// GetEtcdStorageDataForNamespace returns etcd data for all persisted objects.
	// It is exported so that it can be reused across multiple tests.
	// It returns a new map on every invocation to prevent different tests from mutating shared state.
	// Namespaced objects keys are computed for the specified namespace.
	func GetEtcdStorageDataForNamespace(namespace string) map[schema.GroupVersionResource]StorageData {

[k8s-ci-robot]

@sttts: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-node-e2e-containerd	ab86b9c	link	true	/test pull-kubernetes-node-e2e-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sttts]

/hold
/close

Upstream runs this test as integration test. There is no node controller racing with the test. openshift/origin#26490 is the better solution.

[k8s-ci-robot]

@sttts: Closed this PR.

In response to this:

/hold
/close

Upstream runs this test as integration test. There is no node controller racing with the test. openshift/origin#26490 is the better solution.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.