-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the e2e_node runner to receive a KubeletConfiguration rather than requiring flags #105575
Merged
k8s-ci-robot
merged 7 commits into
kubernetes:master
from
endocrimes:dani/cleanup-launcher
Nov 3, 2021
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7dbbfe3
e2e_node: remote runner: junitFilePrefix -> junitFileName
endocrimes 26980cf
e2e_node: cleanup entrypoint
endocrimes f1deb0b
e2e_node: remote: add kubeletconfig to archive
endocrimes 4097a3d
e2e_node: allow customizing the base kubeletconfig
endocrimes 6e9e436
e2e_node: kubelet config: move to file where possible
endocrimes a4cf3a9
e2e_node: support passing kubelet-config-file to local runs
endocrimes 4ae64bd
e2e_node: add a default kubeletconfig fallback
endocrimes File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
apiVersion: kubelet.config.k8s.io/v1beta1 | ||
kind: KubeletConfiguration | ||
cgroupDriver: cgroupfs | ||
cgroupRoot: / | ||
endocrimes marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
# Assign a fixed CIDR to the node because we do not run a node controller | ||
# This MUST be in sync with IPs in: | ||
# - cluster/gce/config-test.sh and | ||
# - test/e2e_node/conformance/run_test.sh | ||
podCIDR: "10.100.0.0/24" | ||
endocrimes marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
# Aggregate volumes frequently to reduce test wait times | ||
volumeStatsAggPeriod: 10s | ||
# Check files frequently to reduce test wait times | ||
fileCheckFrequency: 10s | ||
|
||
evictionPressureTransitionPeriod: 30s | ||
evictionHard: | ||
memory.available: 250Mi | ||
nodefs.available: 10% | ||
nodefs.inodesFree: 5% | ||
evictionMinimumReclaim: | ||
nodefs.available: 5% | ||
nodefs.inodesFree: 5% | ||
|
||
serializeImagePulls: false | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a better place to put this than a so-called jenkins directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet - I want to restructure that - but that's where our image configs live too (so felt like the natural place to park this for now).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forget how much of cluster/ and kube-up.sh this relies on... I could see a case being made that it should move closer to e.g.
config-test.sh
. But I'm also fine with following historical precedent, I know the jenkins dir is basically where (some) node e2e CI config lives (kubernetes/test-infra/jobs/e2e_node being the other historical oddity)