New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm: Replace int with constants #105871
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hwdef The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/triage accepted |
dce2d80
to
ec8b663
Compare
nice catch! 😄 |
/test pull-kubernetes-integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello. V1beta2 includes token logic thst has moved outside to a separate api. With v1beta2 being removed in the future this import will not be needed.
Thanks for the pr though.
/close
@neolit123: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
kubeadm: Replace int with constants
Special notes for your reviewer:
Solution from #105807
Does this PR introduce a user-facing change?