serviceaccount/claims: include validation failure error in the log #105917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
priority/important-longterm
k8s-ci-robot
removed
the
do-not-merge/needs-sig
|
/retest |
liggitt
reviewed
Oct 26, 2021
enj
force-pushed
the
enj/i/sa_err_print
branch
from
69215f8
to
4bf7336
Compare
k8s-ci-robot
added
size/M
enj
force-pushed
the
enj/i/sa_err_print
branch
from
4bf7336
to
e25633c
Compare
k8s-ci-robot
added
size/L
liggitt
reviewed
Oct 27, 2021
pkg/serviceaccount/claims.go
Outdated
| klog.Errorf("unexpected validation error: %T", err) | ||
| return nil, errors.New("Token could not be validated.") | ||
| klog.Errorf("service account token claim validation got unexpected error type: %T", err) // avoid leaking unexpected information into the logs | ||
| return nil, errors.New("service account token claims could not be validated") // return an opaque error |
There was a problem hiding this comment.
I'd recommend returning a distinct error from line 115
|
one comment on the message returned for the unexpected default case, then lgtm |
Without this fix, the errors are logged as: unexpected validation error: *errors.errorString Signed-off-by: Monis Khan <mok@vmware.com>
enj
force-pushed
the
enj/i/sa_err_print
branch
from
e25633c
to
92c8596
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enj, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix, the errors are logged as:
Signed-off-by: Monis Khan mok@vmware.com
/kind bug
/milestone v1.23
/triage accepted
/priority important-longterm
/assign @liggitt