-
Notifications
You must be signed in to change notification settings - Fork 39.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc iptables proxy fixes #106030
Merged
k8s-ci-robot
merged 8 commits into
kubernetes:master
from
danwinship:session-affinity-readiness
Nov 5, 2021
Merged
misc iptables proxy fixes #106030
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0868019
proxy/iptables: Fix sync_proxy_rules_iptables_total metric
danwinship a1a12ca
proxy/iptables: Improve the sorting logic in TestOverallIPTablesRules…
danwinship 9403bfb
proxy/iptables: Misc improvements to unit test
danwinship 799c222
proxy/iptables: test that we create a consistent set of iptables rules
danwinship 22a951c
proxy/iptables: Fix TestOnlyLocalNodePortsNoClusterCIDR
danwinship 6ab3dc6
proxy/iptables: Add more stuff to the unit test
danwinship 3679639
proxy/iptables: Remove a no-op check
danwinship 229ae58
proxy/iptables: fix all-vs-ready endpoints a bit
danwinship File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(ignore if not important) quick thought ... since these
hasLocalServingTerminatingEndpoints
hasLocalReadyEndpoints
variables are just used to calculateuseTerminatingEndpoints
can we move this bit of if/else another function? just for understandability ... not important but just thinkinig out loud trying to reverse engineer the code.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should do some careful refactoring of all this code (I started some in #106158) but we can do those as small followups. Balancing readability of this code with the desire to DRY is hard.