Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: cleanup the feature gate of dual-stack. #106648

Merged
merged 1 commit into from Dec 16, 2021
Merged

kubeadm: cleanup the feature gate of dual-stack. #106648

merged 1 commit into from Dec 16, 2021

Conversation

calvin0327
Copy link
Contributor

@calvin0327 calvin0327 commented Nov 24, 2021 •
edited by k8s-ci-robot

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Clean up the feature gate of dual-stack.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

I find no redundant logic for it. So just delete the variable.

Does this PR introduce a user-facing change?

kubeadm: remove the IPv6DualStack feature gate. The feature has been GA and locked to enabled since 1.23.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 24, 2021
@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 24, 2021
@pacoxu
Copy link
Member

pacoxu commented Nov 24, 2021

/test pull-kubernetes-verify

/home/prow/go/src/k8s.io/kubernetes/api/openapi-spec is out of date. Please run hack/update-openapi-spec.sh

neolit123
neolit123 reviewed Nov 24, 2021
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR, but this has to wait for 1.24.
the feature gate is planned for removal then.

see kubernetes/kubeadm#1612

/milestone v1.24

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Nov 24, 2021
@neolit123
Copy link
Member

these locations also have to be updated:
https://github.com/kubernetes/kubernetes/blob/bf000e87700a553d3936702c3c572be298bae5be/cmd/kubeadm/test/cmd/init_test.go
https://github.com/kubernetes/kubernetes/blob/35f9bcabf1ea3d520c4cfe2b18fa0a0b3ab9a4ed/cmd/kubeadm/app/componentconfigs/kubeproxy.go
https://github.com/kubernetes/kubernetes/blob/b0bc8adbc2178e15872f9ef040355c51c45d04bb/test/e2e_kubeadm/networking_test.go

to not include mentions / usage of the feature gate.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2021
@calvin0327
Copy link
Contributor Author

👍 I'm just checking to see if this variable is being used, which is really not appropriate.

@pacoxu
Copy link
Member

pacoxu commented Dec 2, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2021
@pacoxu
Copy link
Member

pacoxu commented Dec 15, 2021

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 15, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Dec 15, 2021
@neolit123
Copy link
Member

/release-note-edit

kubeadm: remove the IPv6DualStack feature gate. The feature has been GA and locked to enabled since 1.23.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 16, 2021
neolit123
neolit123 reviewed Dec 16, 2021
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: calvin0327, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 522c1be into kubernetes:master Dec 16, 2021
@neolit123 neolit123 mentioned this pull request Dec 16, 2021
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@pacoxu pacoxu Awaiting requested review from pacoxu

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees

@pacoxu pacoxu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@calvin0327 @pacoxu @neolit123 @k8s-ci-robot