Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove docker as container runtime for local-up-cluster.sh #106909

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Remove docker as container runtime for local-up-cluster.sh #106909

merged 1 commit into from
Dec 21, 2021

Conversation

adisky
Copy link
Contributor

@adisky adisky commented Dec 9, 2021

Signed-off-by: Aditi Sharma adi.sky17@gmail.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Dockershim as runtime is removed from k/k removing the same from local-up-cluster.sh and setting default to containerd

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 9, 2021
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 9, 2021 •
edited

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 9, 2021
@adisky adisky force-pushed the remove-docker-from-hack-local-up branch from c7378f2 to 393f130 Compare December 9, 2021 10:56
@adisky adisky mentioned this pull request Dec 9, 2021
Merged
@MadhavJivrajani
Copy link
Contributor

/sig node
/priority important-soon

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 9, 2021
@adisky
Copy link
Contributor Author

adisky commented Dec 9, 2021 •
edited

Need to migrate pull-kubernetes-local-e2e to use containerd

@aojea aojea mentioned this pull request Dec 10, 2021
Closed
@ehashman
Copy link
Member

Need to migrate pull-kubernetes-local-e2e to use containerd

We are dealing with migrating presubmits later (kubernetes/test-infra#24620), we can ignore any optional presubmits that rely on right now. I'll manually test it.

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 10, 2021
@ehashman
Copy link
Member

flake #106904

/retest-required
/skip

ehashman
ehashman reviewed Dec 11, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Worked when I pulled it down locally.

@adisky can you please update the presubmit job as needed in test-infra?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2021
@ehashman ehashman added this to Needs Approver in SIG Node PR Triage Dec 11, 2021
@adisky adisky force-pushed the remove-docker-from-hack-local-up branch from 393f130 to 139c2dd Compare December 13, 2021 09:22
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2021
@adisky adisky force-pushed the remove-docker-from-hack-local-up branch from 139c2dd to 0629c4d Compare December 13, 2021 09:57
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adisky, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2021
@pacoxu
Copy link
Member

pacoxu commented Dec 21, 2021

/test pull-kubernetes-integration
/check-cla

@hakman
Copy link
Member

hakman commented Dec 21, 2021

/test pull-kubernetes-unit
/test pull-kubernetes-e2e-gce-ubuntu-containerd

@adisky
Remove docker as container runtime for local-up
e3b92ad 
Signed-off-by: Aditi Sharma <adi.sky17@gmail.com>
@adisky adisky force-pushed the remove-docker-from-hack-local-up branch from 0cf46dd to e3b92ad Compare December 21, 2021 06:08
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 21, 2021
@adisky
Copy link
Contributor Author

adisky commented Dec 21, 2021

/skip pull-kubernetes-local-e2e

@adisky
Copy link
Contributor Author

adisky commented Dec 21, 2021

/skip

@adisky
Copy link
Contributor Author

adisky commented Dec 21, 2021

@pacoxu @hakman @aojea can you add an lgtm again?

@hakman
Copy link
Member

hakman commented Dec 21, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 21, 2021
@hakman
Copy link
Member

hakman commented Dec 21, 2021

/test pull-kubernetes-integration

@adisky
Copy link
Contributor Author

adisky commented Dec 21, 2021

/skip

@hakman
Copy link
Member

hakman commented Dec 21, 2021 •
edited

Unrelated flake in pull-kubernetes-integration:

FAIL: TestCronJobLaunchesPodAndCleansUp

@hakman
Copy link
Member

hakman commented Dec 21, 2021

/test pull-kubernetes-integration

3 similar comments
@hakman
Copy link
Member

hakman commented Dec 21, 2021

/test pull-kubernetes-integration

@hakman
Copy link
Member

hakman commented Dec 21, 2021

/test pull-kubernetes-integration

@hakman
Copy link
Member

hakman commented Dec 21, 2021

/test pull-kubernetes-integration

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 21, 2021 •
edited

@adisky: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-local-e2e e3b92ad link false /test pull-kubernetes-local-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hakman
Copy link
Member

hakman commented Dec 21, 2021

/test pull-kubernetes-node-e2e-containerd

@k8s-ci-robot k8s-ci-robot merged commit a8cb4e2 into kubernetes:master Dec 21, 2021
SIG Node PR Triage automation moved this from Needs Approver to Done Dec 21, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Dec 21, 2021
@adisky adisky deleted the remove-docker-from-hack-local-up branch December 21, 2021 15:19
@kolyshkin kolyshkin mentioned this pull request Dec 21, 2021
Closed
@atiratree atiratree mentioned this pull request Jan 10, 2022
Merged
@nckturner nckturner mentioned this pull request Jan 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehashman ehashman ehashman left review comments

@lavalamp lavalamp Awaiting requested review from lavalamp

@mikedanese mikedanese Awaiting requested review from mikedanese

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@dims dims Awaiting requested review from dims

Assignees

@dims dims

@hakman hakman

@ehashman ehashman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@adisky @MadhavJivrajani @ehashman @nee1esh @SergeyKanzhelev @aojea @dims @k8s-ci-robot @pacoxu @hakman