Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies: Update golang.org/x/net to v0.0.0-20211209124913-491a49abca63 #106947

Closed
wants to merge 1 commit into from
Closed

dependencies: Update golang.org/x/net to v0.0.0-20211209124913-491a49abca63 #106947

wants to merge 1 commit into from

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Dec 10, 2021 •
edited

What type of PR is this?

/kind feature
/area dependency release-eng release-eng/security security

What this PR does / why we need it:

Update golang.org/x/net to v0.0.0-20211209124913-491a49abca63

  1. ./hack/pin-dependency.sh golang.org/x/net v0.0.0-20211209124913-491a49abca63
  2. ./hack/update-vendor.sh
  3. ./hack/update-internal-modules.sh

Part of kubernetes/release#2349

/assign @liggitt @justaugustus
cc: @kubernetes/release-engineering

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Update golang.org/x/net to v0.0.0-20211209124913-491a49abca63

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 10, 2021
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/dependency Issues or PRs related to dependency changes labels Dec 10, 2021
@k8s-ci-robot
Copy link
Contributor

@cpanato: The label(s) area/release-eng/security cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind feature
/area dependency release-eng release-eng/security security

What this PR does / why we need it:

Update golang.org/x/net to v0.0.0-20211209124913-491a49abca63

  1. ./hack/pin-dependency.sh golang.org/x/net v0.0.0-20211209124913-491a49abca63
  2. ./hack/update-vendor.sh
  3. ./hack/update-internal-modules.sh

It added the github.com/go-openapi/spec not sure if its ok to keep

Part of kubernetes/release#2349

/assign @liggitt @justaugustus
cc: @kubernetes/release-engineering

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Update golang.org/x/net to v0.0.0-20211209124913-491a49abca63

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject area/security cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 10, 2021
@cpanato
Copy link
Member Author

cpanato commented Dec 10, 2021

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 10, 2021
@cpanato cpanato mentioned this pull request Dec 10, 2021
Closed
27 tasks
@k8s-ci-robot k8s-ci-robot requested review from ahg-g, andrewsykim and a team December 10, 2021 10:51
@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/code-generation area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 10, 2021
@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Dec 10, 2021
@cpanato
dependencies: Update golang.org/x/net to v0.0.0-20211209124913-491a49…
a9c8b2b 
…abca63

Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 10, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cpanato
To complete the pull request process, please ask for approval from liggitt after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cpanato
cpanato commented Dec 10, 2021
View reviewed changes
staging/src/k8s.io/code-generator/go.mod
@@ -22,4 +23,8 @@ require (
sigs.k8s.io/structured-merge-diff/v4 v4.1.2 // indirect
)

replace k8s.io/code-generator => ../code-generator
replace (
github.com/go-openapi/jsonreference => github.com/go-openapi/jsonreference v0.19.5
Copy link
Member Author

@cpanato cpanato Dec 10, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here it sets v0.19.5 and above v0.19.6, same in other cases, not sure if is right

@k8s-ci-robot
Copy link
Contributor

@cpanato: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-kind-ipv6 5952ef8a6c1e50d06dafde40ba87b234c72a72dd link true /test pull-kubernetes-e2e-kind-ipv6
pull-kubernetes-dependencies a9c8b2b link true /test pull-kubernetes-dependencies

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cpanato
Copy link
Member Author

cpanato commented Dec 10, 2021

i think i messed this branch, will start using a cleaning one

/close

@k8s-ci-robot
Copy link
Contributor

@cpanato: Closed this PR.

In response to this:

i think i messed this branch, will start using a cleaning one

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato cpanato deleted the update-golang-x-net branch December 10, 2021 16:19
@roycaihw
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 14, 2021
@danwinship danwinship mentioned this pull request Mar 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g Awaiting requested review from ahg-g

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

Assignees

@justaugustus justaugustus

@liggitt liggitt

Labels
area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl area/release-eng Issues or PRs related to the Release Engineering subproject area/security cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cpanato @k8s-ci-robot @roycaihw @justaugustus @liggitt