Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kubectl completion zsh to use any command name rather than hardcoded kubectl #106969

Merged
merged 2 commits into from Jan 5, 2022
Merged

Fix kubectl completion zsh to use any command name rather than hardcoded kubectl #106969

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
339c361
kubectl: fix hard-coded value in zsh completion
Dec 7, 2021
77be26c
Replace hardcoded kubectl with kubectl.Name()
Dec 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion staging/src/k8s.io/kubectl/pkg/cmd/completion/completion.go
View file
Open in desktop
Expand Up @@ -17,6 +17,7 @@ limitations under the License.
package completion

import (
"fmt"
"io"

"github.com/spf13/cobra"
Expand Down Expand Up @@ -170,7 +171,7 @@ func runCompletionBash(out io.Writer, boilerPlate string, kubectl *cobra.Command
}

func runCompletionZsh(out io.Writer, boilerPlate string, kubectl *cobra.Command) error {
zshHead := "#compdef kubectl\ncompdef _kubectl kubectl\n"
zshHead := fmt.Sprintf("#compdef %[1]s\ncompdef _%[1]s %[1]s\n", kubectl.Name())
out.Write([]byte(zshHead))

if len(boilerPlate) == 0 {
Expand Down