-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset metric observed by TestProxyHandler for repeatable test runs. #107060
Reset metric observed by TestProxyHandler for repeatable test runs. #107060
Conversation
This test expects x509_missing_san_total to be 1. When run with -test.count greater than 1, that expectation is unmet for all but the first test run.
Hi @benluddy. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
with this PR
|
/retest |
/triage accepted |
@liggitt for approval |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This test expects x509_missing_san_total to be 1. When run with
-test.count greater than 1, that expectation is unmet for all but the
first test run.
What type of PR is this?
/kind bug
/kind failing-test
What this PR does / why we need it:
Fixes TestProxyHandler, which depends on the value of a global counter, when tests are executed with -test.count greater than 1.
Which issue(s) this PR fixes:
Fixes #107059
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: