Fix default config flags

[jonnylangefeld]

This is a follow up to #105520 which only changed the new default config flags in the NewKubectlCommand function if kubeConfigFlags == nil. However they are not nil because they were initialized before here:

kubernetes/staging/src/k8s.io/kubectl/pkg/cmd/cmd.go

Line 97 in 2fe968d

ConfigFlags: genericclioptions.NewConfigFlags(true).WithDeprecatedPasswordFlag(),

This fix uses the same defaults for both functions

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

It completes an older PR #105520 which missed to set the newly introduced default discovery burst in the NewDefaultKubectlCommand function. It only set it in the NewKubectlCommand function if kubeConfigFlags == nil, which never happened because it was already initialized in the NewDefaultKubectlCommand function as shown above.

kubernetes/staging/src/k8s.io/kubectl/pkg/cmd/cmd.go

Lines 296 to 297 in 2fe968d

	if kubeConfigFlags == nil {
	kubeConfigFlags = genericclioptions.NewConfigFlags(true).WithDeprecatedPasswordFlag().WithDiscoveryBurst(300).WithDiscoveryQPS(50.0)

The difference is demonstrated with these two builds:

Build of this PR (c4fbd35):

╰─ time ./_output/bin/kubectl get pods
NAME      READY   STATUS    RESTARTS   AGE
toolbox   1/1     Running   0          4d1h
./_output/bin/kubectl get pods  0.54s user 1.23s system 12% cpu 14.245 total

Build of current master (489fb9b):

╰─ time ./_output/bin/kubectl get pods
I1219 19:48:52.781276   28978 request.go:665] Waited for 1.196431349s due to client-side throttling, not priority and fairness, request: GET:https://10.216.1.114/apis/networking.gke.io/v1beta2?timeout=32s
I1219 19:49:02.977362   28978 request.go:665] Waited for 11.392070918s due to client-side throttling, not priority and fairness, request: GET:https://10.216.1.114/apis/kms.cnrm.cloud.google.com/v1beta1?timeout=32s
NAME      READY   STATUS    RESTARTS   AGE
toolbox   1/1     Running   0          4d1h
./_output/bin/kubectl get pods  0.56s user 1.21s system 5% cpu 31.313 total

Which issue(s) this PR fixes:

Fixes #105520

Special notes for your reviewer:

/assign @seans3 @lavalamp @justinsb @soltysh

Does this PR introduce a user-facing change?

Fix kubectl config flags incorrectly setting burst and discovery limits

[k8s-ci-robot]

Hi @jonnylangefeld. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jonnylangefeld]

/release-note-none

[soltysh]

/lgtm
/approve
/triage accepted
/priority backlog
/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonnylangefeld, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/kubectl/OWNERS [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jonnylangefeld]

/retest

[eddiezane]

/release-note-edit

Fix kubectl config flags incorrectly setting burst and discovery limits