New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix order of commands in the snapshot tests for persistent volumes #107173
Fix order of commands in the snapshot tests for persistent volumes #107173
Conversation
@mauriciopoppe: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/sig storage |
@@ -451,11 +457,9 @@ func (s *snapshottableTestSuite) DefineTests(driver storageframework.TestDriver, | |||
StopPod(cs, restoredPod) | |||
}) | |||
framework.ExpectNoError(e2epod.WaitTimeoutForPodRunningInNamespace(cs, restoredPod.Name, restoredPod.Namespace, f.Timeouts.PodStartSlow)) | |||
if pattern.VolType != storageframework.GenericEphemeralVolume { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this pattern check is no longer needed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah not needed, the first lines of this test skip it if it's ephemeral so when we get here it's guaranteed that it's not ephemeral, there's another test that only runs for the ephemeral case
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingxu97, mauriciopoppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mauriciopoppe can we backport this test fix to 1.23? |
@msau42 sure, cherrypick for 1.23 is at https://github.com/kubernetes/kubernetes/pull/107341/files |
…f-#107173-upstream-release-1.23 Automated cherry pick of #107173: Fix order of commands in the snapshot tests for persistent
What type of PR is this?
/kind bug
/kind cleanup
Optionally add one or more of the following kinds if applicable:
/kind failing-test
/kind regression
What this PR does / why we need it:
In the refactor done in #105659 the snapshot tests were split to work for ephemeral volumes and for persistent volumes, in the refactor the order of execution of some commands were changed, the order was restored to be like it was before the refactor:
Does this PR introduce a user-facing change?
/cc @pohly @jingxu97 @msau42