Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #106280: Set max results if its not set #107653

Merged
merged 1 commit into from Jan 28, 2022
Merged

Automated cherry pick of #106280: Set max results if its not set #107653

merged 1 commit into from Jan 28, 2022

Conversation

nckturner
Copy link
Contributor

@nckturner nckturner commented Jan 20, 2022 •
edited

Cherry pick of #106280 on release-1.21.

#106280: Set max results if its not set

For details on the cherry pick process, see the cherry pick requests page.

NONE

@nckturner
Set max results if its not set
6972f63 
* If max results is not set and instance IDs are not provided for the
  describe instances call in the aws cloud provider, set max results.
* This prevents an expensive call against the EC2 API, which can
  result in timeouts.
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 20, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 20, 2022
@k8s-ci-robot
Copy link
Contributor

@nckturner: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 20, 2022
@k8s-ci-robot k8s-ci-robot added area/cloudprovider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 20, 2022
@ialidzhikov
Copy link
Contributor

/kind bug
/sig cloud-provider
/cc @cheftako @andrewsykim

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 22, 2022
andrewsykim
andrewsykim reviewed Jan 25, 2022
View reviewed changes
Copy link
Member

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

ack'ing bug fix

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2022
@nckturner
Copy link
Contributor Author

/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team January 26, 2022 23:02
@nckturner
Copy link
Contributor Author

/test pull-kubernetes-e2e-kind-ipv6

@nckturner
Copy link
Contributor Author

/cc kubernetes/release-managers

@M00nF1sh
Copy link
Contributor

/lgtm
/approve

@M00nF1sh
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2022
@puerco
Copy link
Member

puerco commented Jan 27, 2022

/test pull-kubernetes-e2e-kind-ipv6

@nckturner
Copy link
Contributor Author

Looks like it passed 👍

@puerco
Copy link
Member

puerco commented Jan 28, 2022

/lgtm

@puerco puerco added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 28, 2022
@ialidzhikov
Copy link
Contributor

@puerco , the bot didn’t remove the “do-not-merge/cherry-pick-not-approved” label.

@saschagrunert saschagrunert added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 28, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, M00nF1sh, nckturner, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b37aecf into kubernetes:release-1.21 Jan 28, 2022
@kschumy kschumy mentioned this pull request May 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim andrewsykim left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

@gnufied gnufied Awaiting requested review from gnufied

@micahhausler micahhausler Awaiting requested review from micahhausler

@cheftako cheftako Awaiting requested review from cheftako

Assignees

@puerco puerco

@M00nF1sh M00nF1sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@nckturner @k8s-ci-robot @ialidzhikov @M00nF1sh @puerco @saschagrunert @andrewsykim