Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for CRI verbose fields #107945

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Add support for CRI verbose fields #107945

merged 1 commit into from
Feb 15, 2022

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The remote runtime implementation now supports the verbose fields,
which are required for consumers like cri-tools to enable multi CRI
version support.

Which issue(s) this PR fixes:

Refers to kubernetes-sigs/cri-tools#889

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 4, 2022
@saschagrunert saschagrunert mentioned this pull request Feb 4, 2022
Merged
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 4, 2022
@saschagrunert
Copy link
Member Author

/test pull-kubernetes-node-e2e-containerd

@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 4, 2022
@saschagrunert
Copy link
Member Author

/test pull-kubernetes-node-e2e-containerd

@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Copy link
Member Author

/test pull-kubernetes-node-e2e-containerd

@saschagrunert saschagrunert force-pushed the cri-verbose branch 2 times, most recently from 55427a3 to 6a33e8f Compare February 7, 2022 10:53
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Archive-it in SIG Node CI/Test Board Feb 9, 2022
@SergeyKanzhelev
Copy link
Member

/assign
/triage accepted
/priority important-soon

(important soon as needed for cri tools)

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 9, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 9, 2022
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Needs Reviewer in SIG Node PR Triage Feb 9, 2022
@pacoxu
Copy link
Member

pacoxu commented Feb 10, 2022

/cc haircommander @mrunalp

pacoxu
pacoxu reviewed Feb 10, 2022
View reviewed changes
Copy link
Member

@pacoxu pacoxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the nit.

pkg/kubelet/kuberuntime/kuberuntime_container.go Show resolved Hide resolved
@saschagrunert
Add support for CRI verbose fields
effbcd3 
The remote runtime implementation now supports the `verbose` fields,
which are required for consumers like cri-tools to enable multi CRI
version support.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert saschagrunert force-pushed the cri-verbose branch 2 times, most recently from 6a33e8f to 10b9407 Compare February 10, 2022 16:12
pacoxu
pacoxu approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@pacoxu pacoxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2022
@dims
Copy link
Member

dims commented Feb 11, 2022

/milestone v1.24

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 11, 2022
@ehashman ehashman moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Feb 11, 2022
@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Feb 15, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, pacoxu, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit 64e83a7 into kubernetes:master Feb 15, 2022
SIG Node CI/Test Board automation moved this from Archive-it to Done Feb 15, 2022
@saschagrunert saschagrunert deleted the cri-verbose branch February 15, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@pacoxu pacoxu pacoxu approved these changes

@yujuhong yujuhong Awaiting requested review from yujuhong

@haircommander haircommander Awaiting requested review from haircommander

Assignees

@pacoxu pacoxu

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@saschagrunert @SergeyKanzhelev @pacoxu @dims @k8s-ci-robot @mrunalp