Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove audit.k8s.io/v1[alpha|beta]1 versions #108092

Merged
merged 1 commit into from Mar 8, 2022
Merged

remove audit.k8s.io/v1[alpha|beta]1 versions #108092

merged 1 commit into from Mar 8, 2022

Conversation

carlory
Copy link
Member

@carlory carlory commented Feb 13, 2022 •
edited by liggitt

What type of PR is this?

/kind cleanup
/kind feature
/kind api-change

Which issue(s) this PR fixes:

Fixes #98035

Does this PR introduce a user-facing change?

kube-apiserver: --audit-log-version and --audit-webhook-version now only support the default value of audit.k8s.io/v1. The v1alpha1 and v1beta1 audit log versions, deprecated since 1.13, have been removed.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 13, 2022
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 13, 2022
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@enj enj added this to Needs Triage in SIG Auth Old Feb 14, 2022
@fedebongio
Copy link
Contributor

Hi @carlory we triaged this one, and wondered if it would be good to discuss in the next SIG meeting. I'm adding it to the agenda.

@carlory
Copy link
Member Author

carlory commented Feb 16, 2022

@fedebongio yeah，I will do it this week.

@fedebongio
Copy link
Contributor

/triage accepted
Thank you, and see you next week!

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 17, 2022
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 21, 2022
@carlory
Copy link
Member Author

carlory commented Feb 22, 2022

/test pull-kubernetes-conformance-kind-ipv6-parallel
/test pull-kubernetes-unit

@k8s-ci-robot k8s-ci-robot requested a review from ritazh March 2, 2022 00:55
deads2k
deads2k reviewed Mar 3, 2022
View reviewed changes
staging/src/k8s.io/apiserver/pkg/server/options/audit.go
@@ -235,8 +233,6 @@ func validateBackendBatchOptions(pluginName string, options AuditBatchOptions) e
}

var knownGroupVersions = []schema.GroupVersion{
auditv1alpha1.SchemeGroupVersion,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note to self for future me. This is used a few lines down in a validate method and will prevent the server from starting if the value is anything except v1.

@deads2k
Copy link
Contributor

deads2k commented Mar 3, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2022
@carlory
Copy link
Member Author

carlory commented Mar 5, 2022 •
edited

/assign @liggitt

@k8s-ci-robot
Copy link
Contributor

@carlory: GitHub didn't allow me to assign the following users: i.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @liggitt i

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liggitt
Copy link
Member

liggitt commented Mar 7, 2022

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2022
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

2 similar comments
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@pacoxu
Copy link
Member

pacoxu commented Mar 8, 2022

/lgtm cancel
To verify test failures, you need to run the make update.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, deads2k, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@carlory
Copy link
Member Author

carlory commented Mar 8, 2022

/cc @pacoxu

@k8s-ci-robot k8s-ci-robot requested a review from pacoxu March 8, 2022 08:56
@pacoxu
Copy link
Member

pacoxu commented Mar 8, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1976240 into kubernetes:master Mar 8, 2022
SIG Auth Old automation moved this from In Review to Closed / Done Mar 8, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 8, 2022
@Riaankl Riaankl mentioned this pull request Mar 14, 2022
Closed
This was referenced Mar 22, 2022
Open
Open
@bxy4543 bxy4543 mentioned this pull request May 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@lavalamp lavalamp Awaiting requested review from lavalamp

@fedebongio fedebongio Awaiting requested review from fedebongio

@ritazh ritazh Awaiting requested review from ritazh

@pacoxu pacoxu Awaiting requested review from pacoxu

Assignees

@liggitt liggitt

@pacoxu pacoxu

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/code-generation area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG Auth Old
Closed / Done
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

Deprecate and Remove audit.k8s.io/v1[alpha|beta]1 Versions
8 participants
@carlory @k8s-triage-robot @fedebongio @deads2k @k8s-ci-robot @liggitt @pacoxu @ritazh