Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RuntimeClass and PodOverhead tests promotion to Conformance #108781

Merged
merged 1 commit into from
Mar 24, 2022
Merged

RuntimeClass and PodOverhead tests promotion to Conformance #108781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
30 changes: 30 additions & 0 deletions test/conformance/testdata/conformance.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2112,6 +2112,36 @@
patch, delete, and deletecollection.'
release: v1.20
file: test/e2e/common/node/runtimeclass.go
- testname: Pod with the deleted RuntimeClass is rejected.
codename: '[sig-node] RuntimeClass should reject a Pod requesting a deleted RuntimeClass
[NodeConformance] [Conformance]'
description: Pod requesting the deleted RuntimeClass must be rejected.
release: v1.20
file: test/e2e/common/node/runtimeclass.go
- testname: Pod with the non-existing RuntimeClass is rejected.
codename: '[sig-node] RuntimeClass should reject a Pod requesting a non-existent
RuntimeClass [NodeConformance] [Conformance]'
description: The Pod requesting the non-existing RuntimeClass must be rejected.
release: v1.20
file: test/e2e/common/node/runtimeclass.go
- testname: RuntimeClass Overhead field must be respected.
codename: '[sig-node] RuntimeClass should schedule a Pod requesting a RuntimeClass
and initialize its Overhead [NodeConformance] [Conformance]'
description: The Pod requesting the existing RuntimeClass must be scheduled. This
test doesn't validate that the Pod will actually start because this functionality
depends on container runtime and preconfigured handler. Runtime-specific functionality
is not being tested here.
release: v1.24
file: test/e2e/common/node/runtimeclass.go
- testname: Can schedule a pod requesting existing RuntimeClass.
codename: '[sig-node] RuntimeClass should schedule a Pod requesting a RuntimeClass
without PodOverhead [NodeConformance] [Conformance]'
description: The Pod requesting the existing RuntimeClass must be scheduled. This
test doesn't validate that the Pod will actually start because this functionality
depends on container runtime and preconfigured handler. Runtime-specific functionality
is not being tested here.
release: v1.20
file: test/e2e/common/node/runtimeclass.go
- testname: Secrets, pod environment field
codename: '[sig-node] Secrets should be consumable from pods in env vars [NodeConformance]
[Conformance]'
Expand Down
8 changes: 4 additions & 4 deletions test/e2e/common/node/runtimeclass.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ var _ = SIGDescribe("RuntimeClass", func() {
Testname: Pod with the non-existing RuntimeClass is rejected.
Description: The Pod requesting the non-existing RuntimeClass must be rejected.
*/
ginkgo.It("should reject a Pod requesting a non-existent RuntimeClass [NodeConformance]", func() {
framework.ConformanceIt("should reject a Pod requesting a non-existent RuntimeClass [NodeConformance]", func() {
rcName := f.Namespace.Name + "-nonexistent"
expectPodRejection(f, e2enode.NewRuntimeClassPod(rcName))
})
Expand Down Expand Up @@ -99,7 +99,7 @@ var _ = SIGDescribe("RuntimeClass", func() {
depends on container runtime and preconfigured handler. Runtime-specific functionality
is not being tested here.
*/
ginkgo.It("should schedule a Pod requesting a RuntimeClass without PodOverhead [NodeConformance]", func() {
framework.ConformanceIt("should schedule a Pod requesting a RuntimeClass without PodOverhead [NodeConformance]", func() {
rcName := createRuntimeClass(f, "preconfigured-handler", e2enode.PreconfiguredRuntimeClassHandler, nil)
defer deleteRuntimeClass(f, rcName)
pod := f.PodClient().Create(e2enode.NewRuntimeClassPod(rcName))
Expand All @@ -124,7 +124,7 @@ var _ = SIGDescribe("RuntimeClass", func() {
depends on container runtime and preconfigured handler. Runtime-specific functionality
is not being tested here.
*/
ginkgo.It("should schedule a Pod requesting a RuntimeClass and initialize its Overhead [NodeConformance]", func() {
framework.ConformanceIt("should schedule a Pod requesting a RuntimeClass and initialize its Overhead [NodeConformance]", func() {
rcName := createRuntimeClass(f, "preconfigured-handler", e2enode.PreconfiguredRuntimeClassHandler, &nodev1.Overhead{
PodFixed: v1.ResourceList{
v1.ResourceName(v1.ResourceCPU): resource.MustParse("10m"),
Expand All @@ -151,7 +151,7 @@ var _ = SIGDescribe("RuntimeClass", func() {
Testname: Pod with the deleted RuntimeClass is rejected.
Description: Pod requesting the deleted RuntimeClass must be rejected.
*/
ginkgo.It("should reject a Pod requesting a deleted RuntimeClass [NodeConformance]", func() {
framework.ConformanceIt("should reject a Pod requesting a deleted RuntimeClass [NodeConformance]", func() {
rcName := createRuntimeClass(f, "delete-me", "runc", nil)
rcClient := f.ClientSet.NodeV1().RuntimeClasses()

Expand Down