-
Notifications
You must be signed in to change notification settings - Fork 38.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update for APIs removed in 1.25 #108797
update for APIs removed in 1.25 #108797
Conversation
huh, must have done that wrong. |
/triage accepted |
/remove-sig instrumentation |
799d529
to
ddb57b4
Compare
lgtm... there's a bunch of "remove in 1.25" comments on |
followup. Let's get these unserved first |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
is an infra issue, not a test issue /retest |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
1 similar comment
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
This PR breaks functionality for |
Deprecations are noted in release notes, in docs at https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-25, and every use of a deprecated API returns a warning header in the API response (https://kubernetes.io/blog/2020/09/03/warnings/#deprecation-warnings) I'm happy to update the comment in this PR as well. |
Now updated for a state that is possible to merge. I'll likely pick the test-cmd solution from the PSP admission removal.
/kind cleanup