New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split OpenAPI V2 and V3 Config Initialization #109079
Conversation
@Jefftree: GitHub didn't allow me to request PR reviews from the following users: alexzielenski. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Rebased off latest master branch to avoid a conflict. Please re-lgtm |
/lgtm |
/retest |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
0d42ccd
to
9d21836
Compare
Rebased again due to openapiv3*.json update |
/retest |
/lgtm |
/hold This is covered by #109031 and I'll be rebasing that PR instead going forward |
/triage accepted |
9d21836
to
67d3dbf
Compare
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: apelisse, dims, Jefftree, lavalamp The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Jefftree: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/kind feature
What this PR does / why we need it:
Split up initialization for OpenAPI V2 and V3. This allows the config.GetDefinitions to be called and definitions generated once for all OpenAPI V3 builders rather than generating a new one per group/version.
Commits are separated for easier review:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Wrapping refs with allOfs is a fix for us to publish valid OpenAPI. OpenAPI v3 spec dictates that refs may not have sibling elements which is a condition we violate in OpenAPI V2. See #106387 for more details.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: