Flake fix: validate each expression once in primary CEL correctness suite

[jpbetz]

What type of PR is this?

/kind cleanup
/kind flake

What this PR does / why we need it:

The test suite is compiling and validating each of the many rules it tests three times. The 2nd two times are just to do a sanity check of the cost system, which isn't particularly valuable to test here given all the other tests that cover that.

I've reduced this to a single compile/validate call which reduces the CPU cost of the test by more than half.

Which issue(s) this PR fixes:

Fixes #109225

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

/sig api-machinery

[jpbetz]

/priority critical-urgent
/triage accepted
/assign @cici37

[cici37]

We have test on expression cost but miss the test for hitting limit. Maybe worth to add a separate small test aside for limit check?

[cici37]

/lgtm
The separate test will be added in following up pr.

[jpbetz]

/assign @liggitt
Would you be willing to approve? This is a pretty simple ~3x speed boost to this test suite.

[cici37]

FYI: We have existing test covering runtime cost budget exceed in k8s.io/apiextensions-apiserver/pkg/apiserver/schema/defaulting/validation_test.go so removing the similar test from cel/validation_test should not be a big concern

[liggitt]

/lgtm
/approve

#109239 is likely to resolve the tragically high integration test flake rate

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/apiextensions-apiserver/OWNERS [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[liggitt]

We have existing test covering runtime cost budget exceed in k8s.io/apiextensions-apiserver/pkg/apiserver/schema/defaulting/validation_test.go so removing the similar test from cel/validation_test should not be a big concern

mmm... that's specific to defaulting, though, right? that doesn't seem like the same coverage this is dropping

We have test on expression cost but miss the test for hitting limit. Maybe worth to add a separate small test aside for limit check?

that's a good point. a single test of the limit (rather than exercising N times on N expressions) seems important
/hold

[liggitt]

/milestone v1.24
test-only change, improving test signal before test freeze
/retest

[liggitt]

that's a good point. a single test of the limit (rather than exercising N times on N expressions) seems important

(if the flake is bad, feel free to unhold and re-add that solo test next week)

[cici37]

@liggitt I have the PR open to separating the test here: #109242

[jpbetz]

/hold cancel
We'll merge @cici37's #109242 PR shortly and merge this PR now since this flake is significant.