Use CEL EagerlyValidateDeclarations to improve compilation performance #109835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…laration validation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
sig/api-machinery
|
/assign @jpbetz |
|
I raised this pr as we talked earlier this morning. Would you mind to take a look when have time? Thank you :) @jpbetz |
|
/test pull-kubernetes-integration |
|
/lgtm This looks like the previous PR, I don't see any issues with reapplying it now that CEL is bumped to latest version. |
k8s-ci-robot
added
the
lgtm
|
/test pull-kubernetes-integration |
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
/test pull-kubernetes-integration |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cici37, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
10 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR is a replay of #108954 which be reverted from 1.24
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: