-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor cleanup in apiserver startup in integration tests #109899
Minor cleanup in apiserver startup in integration tests #109899
Conversation
@wojtek-t: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@wojtek-t: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
})) | ||
|
||
_, _, closeFn := framework.RunAnAPIServerUsingServer(framework.NewIntegrationTestControlPlaneConfig(), s, h) | ||
_, s, closeFn := framework.RunAnAPIServer(framework.NewIntegrationTestControlPlaneConfig()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the CloseFn returned already has a s.Close()
kubernetes/test/integration/framework/master_utils.go
Lines 147 to 153 in ce50018
closeFn := func() { | |
if m != nil { | |
m.GenericAPIServer.RunPreShutdownHooks() | |
} | |
close(stopCh) | |
s.Close() | |
} |
I think that the shutdownFunc
can be removed with this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch - PTAL
016b974
to
e6fc605
Compare
/lgtm |
e6fc605
to
ec36d03
Compare
/lgtm |
ec36d03
to
d1c9042
Compare
@aojea - sorry for that, should finally be fixed now (and tests should pass) |
/lgtm |
I start to see this failures on Node tests more often 👀 |
/kind cleanup
/priority important-longerm
/sig testing