Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #109124: Winkernel proxier cache HNS data to improve syncProxyRules #109981

Merged
merged 2 commits into from Jun 9, 2022
Merged

Automated cherry pick of #109124: Winkernel proxier cache HNS data to improve syncProxyRules #109981

merged 2 commits into from Jun 9, 2022

Conversation

marosset
Copy link
Contributor

Cherry pick of #109124 on release-1.23.

#109124: Winkernel proxier cache HNS data to improve syncProxyRules

For details on the cherry pick process, see the cherry pick requests page.

@daschott @marosset
Winkernel proxier cache HNS data to improve syncProxyRules performance
6bf9857 
Resolved issues with proxy rules taking a long time to be synced on Windows, by caching HNS data.

In particular, the following HNS data will be cached for the context of syncProxyRules:
  * HNS endpoints

  * HNS load balancers
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone May 11, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 11, 2022
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 11, 2022
@marosset
Copy link
Contributor Author

/kind bug
/triage accepted
/priority important-soon
/sig windows

@marosset
Copy link
Contributor Author

/assign @daschott @jsturtevant

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels May 11, 2022
@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label May 11, 2022
@k8s-ci-robot
Copy link
Contributor

@marosset: GitHub didn't allow me to assign the following users: daschott.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @daschott @jsturtevant

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 11, 2022
@marosset
Copy link
Contributor Author

/test pull-kubernetes-e2e-aks-engine-windows-containerd-1-23

daschott
daschott reviewed May 11, 2022
View reviewed changes
pkg/proxy/winkernel/proxier.go Outdated
@@ -1320,6 +1352,28 @@ func (proxier *Proxier) syncProxyRules() {
klog.V(3).InfoS("Skipped creating Hns LoadBalancer for loadBalancer Ingress resources", "lbIngressIP", lbIngressIP)
}

if proxier.forwardHealthCheckVip && gatewayHnsendpoint != nil {
Copy link
Contributor

@daschott daschott May 11, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To untangle this from the additions in 78a507b, we need to remove this nested condition.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the health check feature fix landed in 1.24 which is why this needs to be removed here and didn't need to be removed in the backport to 1.24

@daschott
Copy link
Contributor

/retest

@jsturtevant
Copy link
Contributor

/test pull-kubernetes-e2e-aks-engine-windows-containerd-1-23

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2022
@jsturtevant jsturtevant mentioned this pull request May 12, 2022
Merged
@marosset marosset added this to Open backport PRs in SIG-Windows May 18, 2022
@marosset
Copy link
Contributor Author

/assign @feiskyer @khenidak
For windows kernelspace proxy approvals

@cpanato cpanato mentioned this pull request May 20, 2022
Merged
@feiskyer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2022
@marosset
Copy link
Contributor Author

/cc @kubernetes/release-managers
This is ready for final review

@k8s-ci-robot k8s-ci-robot requested a review from a team May 23, 2022 20:14
@zhiweiv
Copy link

zhiweiv commented Jun 9, 2022

May I know when will this be merged? I am experiencing a similar issue and would like to verify if this fix will help.

@puerco
Copy link
Member

puerco commented Jun 9, 2022

Thank you @marosset !!
/lgtm

@puerco puerco added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 9, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jun 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit 4094673 into kubernetes:release-1.23 Jun 9, 2022
SIG-Windows automation moved this from Open backport PRs to Done (v1.25) Jun 9, 2022
@marosset marosset moved this from Done (v1.25) to Done (v1.23) in SIG-Windows Jun 13, 2022
@jsturtevant jsturtevant mentioned this pull request Jun 14, 2022
Merged
This was referenced Jun 15, 2022
Closed
Closed
@marosset marosset deleted the automated-cherry-pick-of-#109124-upstream-release-1.23 branch October 31, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsturtevant jsturtevant jsturtevant left review comments

@daschott daschott daschott left review comments

@kumarvin123 kumarvin123 Awaiting requested review from kumarvin123

@madhanrm madhanrm Awaiting requested review from madhanrm

Assignees

@jsturtevant jsturtevant

@feiskyer feiskyer

@puerco puerco

@khenidak khenidak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG-Windows
  
Done (v1.23)
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@marosset @k8s-ci-robot @daschott @jsturtevant @feiskyer @zhiweiv @puerco @khenidak