Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Endpoints and EndpointSlices should not publish IPs for terminal pods #110255

Merged
merged 6 commits into from
May 27, 2022
Merged

Endpoints and EndpointSlices should not publish IPs for terminal pods #110255

merged 6 commits into from
May 27, 2022

Commits on May 27, 2022

  1. add pod util to verify pod is terminal 

    pods on phase succeeded or failed are guaranteed to have all containers
stopped and to not ever regress
    @aojea
    aojea committed May 27, 2022
    Configuration menu
    Copy the full SHA
    d16d23e View commit details
    Browse the repository at this point in the history

  2. endpointslices: terminal pods doesn't receive enpoints

    @aojea
    aojea committed May 27, 2022
    Configuration menu
    Copy the full SHA
    b905c28 View commit details
    Browse the repository at this point in the history

  3. endpoints controller: don't consider terminal endpoints 

    Terminal pods, whose phase its Failed or Succeeded, are guaranteed
to never regress and to be stopped, so their IPs never should
be published on the Endpoints.
    @aojea
    aojea committed May 27, 2022
    Configuration menu
    Copy the full SHA
    aa35f6f View commit details
    Browse the repository at this point in the history

  4. e2e test for evicted pods

    @aojea
    aojea committed May 27, 2022
    Configuration menu
    Copy the full SHA
    ffdbce6 View commit details
    Browse the repository at this point in the history

  5. e2e: services with evicted pods doesn't have endpoints

    @aojea
    aojea committed May 27, 2022
    Configuration menu
    Copy the full SHA
    3a8edca View commit details
    Browse the repository at this point in the history

  6. Updating e2e test to check EndpointSlices and Endpoints as well

    @robscott
    robscott committed May 27, 2022
    Configuration menu
    Copy the full SHA
    aa02b7a View commit details
    Browse the repository at this point in the history