Commits on Aug 1, 2022

1. unittests: Fixes unit tests for Windows (part 2) …

   Currently, there are some unit tests that are failing on Windows due to
   various reasons:
   
   - volume mounting is a bit different on Windows: Mount will create the
     parent dirs and mklink at the volume path later (otherwise mklink will
     raise an error).
   - os.Chmod is not working as intended on Windows.
   - path.Dir() will always return "." on Windows, and filepath.Dir()
     should be used instead (which works correctly).
   - on Windows, you can't typically run binaries without extensions. If
     the file C:\\foo.bat exists, we can still run C:\\foo because Windows
     will append one of the supported file extensions ($env:PATHEXT) to it
     and run it.
   - Windows file permissions do not work the same way as the Linux ones.
   - /tmp directory being used, which might not exist on Windows. Instead,
     the OS-specific Temp directory should be used.
   
   Fixes a few other issues:
   
   - rbd.go: Return error in a case in which an error is encountered. This
     will prevent "rbd: failed to setup" and "rbd: successfully setup" log
     messages to be logged at the same time.

   

   claudiubelu committed Aug 1, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 38092cb
   • Browse repository at this point

   Copy the full SHA

   38092cb View commit details

   Browse the repository at this point in the history