add requirement for apiversion of unstructured when decoding

[weilaaa]

What type of PR is this?
/kind bug

What this PR does / why we need it:
add requirement for apiversion of unstructured when decoding

Which issue(s) this PR fixes:
#109023

/cc @apelisse @kevindelgado @liggitt
/sig api-machinery

[k8s-ci-robot]

@weilaaa: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @weilaaa. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weilaaa
To complete the pull request process, please assign smarterclayton after the PR has been reviewed.
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• staging/src/k8s.io/apimachinery/pkg/OWNERS
• staging/src/k8s.io/apimachinery/pkg/apis/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-triage-robot]

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

[liggitt]

thanks for the PR... before tightening validation here, the following item from the issue needs research:

Ideally, our decoding would consistently require kind and apiVersion, but we need to understand whether there are any currently working scenarios that are omitting apiVersion from unstructured data before we do so.

[weilaaa]

It seems difficult to check out any currently working scenarios, shall we add warning log here to prompt users to make change?

[leilajal]

/assign @kevindelgado
/triage accepted

[liggitt]

It seems difficult to check out any currently working scenarios, shall we add warning log here to prompt users to make change?

Unfortunately, an error log wouldn't be visible or noticed by API-level callers

At a minimum, the categories of use we'd want to check are from the command line (e.g. kubectl), config files, and the API server decoding requests to typed and untyped APIs via all write methods (create, update, and all supported patch types). If any of those currently accept content without apiVersion and do reasonable things with it, it's going to be hard to make a case for this being a backwards-compatible change.

[weilaaa]

It seems difficult to check out any currently working scenarios, shall we add warning log here to prompt users to make change?

Unfortunately, an error log wouldn't be visible or noticed by API-level callers

At a minimum, the categories of use we'd want to check are from the command line (e.g. kubectl), config files, and the API server decoding requests to typed and untyped APIs via all write methods (create, update, and all supported patch types). If any of those currently accept content without apiVersion and do reasonable things with it, it's going to be hard to make a case for this being a backwards-compatible change.

Thanks for your answer. I will temporarily close this pr, wish it will be reopened in the future. I'm willing to be assigned if needed anyway.