Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CronJob controller cleanups #110838

Merged
merged 2 commits into from
Jan 18, 2023
Merged

CronJob controller cleanups #110838

merged 2 commits into from
Jan 18, 2023

Commits on Jan 18, 2023

  1. Cleanups in controller utils 

    1. Squash two identical sorters byTime
2. Move helper for searching active jobs into utils to exist next to its
  counterpart
    @soltysh
    soltysh committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    cb491a8 View commit details
    Browse the repository at this point in the history

  2. Re-use common parts between getNextScheduleTime and nextScheduledTime… 

    …Duration

The two methods nextScheduledTimeDuration and getNextScheduleTime have a
lot of similarities, so this commit squashes the common parts together
along with getMostRecentScheduleTime to avoid code duplication.
    @soltysh
    soltysh committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    be44d67 View commit details
    Browse the repository at this point in the history