Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: delete same utils.go in pkg/apis/storage #110862

Merged
merged 1 commit into from
Jul 2, 2022

Conversation

Abirdcfly
Copy link
Member

Signed-off-by: Abirdcfly fp544037857@gmail.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

$ diff pkg/apis/storage/util/helpers.go pkg/apis/storage/v1/util/helpers.go
19c19,21
< import metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
---
> import (
>       metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
> )
$ diff pkg/apis/storage/util/helpers.go pkg/apis/storage/v1beta1/util/helpers.go

There are 3 same files here, one is enough.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Signed-off-by: Abirdcfly <fp544037857@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 29, 2022
@k8s-ci-robot
Copy link
Contributor

@Abirdcfly: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/test sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 29, 2022
@Abirdcfly
Copy link
Member Author

Abirdcfly commented Jun 29, 2022

/assign @thockin for approve.PTAL.

I guess pull-kubernetes-e2e-gce-storage-snapshot will fail, already reported by #110658.

update: The assign syntax requires that no other content be added after assign @someone, otherwise k8s-ci-robot will not be assigned successfully. 😯

@yxxhero
Copy link
Member

yxxhero commented Jun 30, 2022

/test pull-kubernetes-e2e-gce-storage-snapshot

@yxxhero
Copy link
Member

yxxhero commented Jun 30, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2022
@k8s-ci-robot
Copy link
Contributor

@Abirdcfly: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-gce-storage-snapshot 1dbd9de link false /test pull-kubernetes-e2e-gce-storage-snapshot

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pohly
Copy link
Contributor

pohly commented Jun 30, 2022

I can't think of a reason why those files should be duplicated, so:
/lgtm
/approve

@Abirdcfly
Copy link
Member Author

Abirdcfly commented Jul 1, 2022

/assign @thockin

for approve.

pull-kubernetes-e2e-gce-storage-snapshot faild is a known issue and has been reported by #110658 and may be fixed by #110826

@thockin
Copy link
Member

thockin commented Jul 2, 2022

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Abirdcfly, pohly, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit 89aaf7c into kubernetes:master Jul 2, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 2, 2022
@Abirdcfly Abirdcfly deleted the deleteutil branch July 4, 2022 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants