kubeadm: prefer to use pkg/errors package and cleanup fmt.Errorf

[SataQiu]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

[kubeadm: prefer to use pkg/errors package and cleanup fmt.Errorf]

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cmd/kubeadm/OWNERS [SataQiu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[neolit123]

we should just use the pkg/errors package and Wrap(f) instead. despite deprecated the library gives us the consistent wrapping that we need. stdlib and %w dont have that.

we might actually fork it at some point.

[neolit123]

/hold

[SataQiu]

we should just use the pkg/errors package and Wrap(f) instead. despite deprecated the library gives us the consistent wrapping that we need. stdlib and %w dont have that.

we might actually fork it at some point.

Emm... On second check, we do use errors.Wrap(f) a lot. So should we use errors.Wrapf instead of fmt.Errorf() in our kubeadm codebase? @neolit123

[neolit123]

So should we use errors.Wrapf instead of fmt.Errorf() in our kubeadm codebase?

yes. in fact we had an effort to clean all usage of fmt.Errorf. (that was when we started using pkg/errors)

[neolit123]

/lgtm
thanks

[neolit123]

/hold cancel
/triage accepted

[SataQiu]

Thanks @neolit123 Need LGTM again
This PR also replaces errors package with prefered "github.com/pkg/errors" package.

[neolit123]

/lgtm

[SataQiu]

/retest

[k8s-triage-robot]

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

• The PR does have any do-not-merge/* labels
• The PR does not have the needs-ok-to-test label
• The PR is mergeable (does not have a needs-rebase label)
• The PR is approved (has cncf-cla: yes, lgtm, approved labels)
• The PR is failing tests required for merge

You can:

• Review the full test history for this PR
• Prevent this bot from retesting with /lgtm cancel or /hold
• Help make our tests less flaky by following our Flaky Tests Guide

/retest