Fix test order staging/src/k8s.io/component-base/logs/json/json_test.go

[muyangren2]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Per https://pkg.go.dev/github.com/stretchr/testify/assert#Equal expected goes before actual:

func Equal(t TestingT, expected, actual interface{}, msgAndArgs ...interface{}) bool

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Fixes tests asserting that the expected values were the actual ones, when they were not. just like
#102611
#102615

Does this PR introduce a user-facing change?

"NONE"

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Hi @muyangren2. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[RainbowMango]

/triage accepted

[RainbowMango]

I noticed that assert.Equal is heavily used in k8s.io/component-base, can you help to confirm if it is the only case in k8s.io/component-base? I mean we can fix all the similar mistakes by this PR.

[yangjunmyfm192085]

/cc @muyangren2 You can find mistakes elsewhere and fix them together

[k8s-ci-robot]

@yangjunmyfm192085: GitHub didn't allow me to request PR reviews from the following users: find, mistakes, muyangren2, You, can, elsewhere, and, fix, them, together.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @muyangren2 You can find mistakes elsewhere and fix them together

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[muyangren2]

I noticed that assert.Equal is heavily used in k8s.io/component-base, can you help to confirm if it is the only case in k8s.io/component-base? I mean we can fix all the similar mistakes by this PR.

ok i will check all and fix it ,thanks

[muyangren2]

I noticed that assert.Equal is heavily used in k8s.io/component-base, can you help to confirm if it is the only case in k8s.io/component-base? I mean we can fix all the similar mistakes by this PR.

I carefully checked k8s.io/component-base This component is only this one, no other

[RainbowMango]

I carefully checked k8s.io/component-base This component is only this one, no other
Thanks.

/ok-to-test

[muyangren2]

/retest

[RainbowMango]

/lgtm
/approve
Thanks.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: muyangren2, RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/component-base/logs/OWNERS [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment