New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix label output bug where dry run message was not printed #111571
Fix label output bug where dry run message was not printed #111571
Conversation
/hold |
/priority important-longterm |
3de02f2
to
2efe97f
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel
/triage accepted |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brianpursley, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Ever since kubectl 1.18-ish, when you use the
--dry-run
flag withkubectl label
, it does not print a message saying it was a dry run, making you think that it might have actually labeled the pod. For example:This PR fixes this bug, so that the output is:
Additional unit tests are added to test the output to make sure the proper dry run message is displayed.
Which issue(s) this PR fixes:
No issue created
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: