New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate LabelSelector
for TopologySpreadConstraints
#112121
Conversation
Signed-off-by: Dave Chen <dave.chen@arm.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chendave The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @liggitt I am trying to reuse some existing method for the validation, pls take a look, thanks! |
/assign @liggitt |
thanks for the PR, I think this is already in progress in #111802 |
/assign @cici37 |
/close in favor of #111802 |
@chendave: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind cleanup
Signed-off-by: Dave Chen dave.chen@arm.com
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
address the comments here: https://github.com/kubernetes/kubernetes/pull/111441/files#r933399816
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: