add v1beta3 for Priority And Fairness

[tkashem]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #107574
Fixes #104842

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Introduce v1beta3 for Priority and Fairness with the following changes to the API spec:
- rename 'assuredConcurrencyShares' (located under spec.limited') to 'nominalConcurrencyShares'
- apply strategic merge patch annotations to 'Conditions' of flowschemas and prioritylevelconfigurations

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[tkashem]

/test pull-kubernetes-e2e-gce-ubuntu-containerd
/test pull-kubernetes-e2e-kind
/test pull-kubernetes-conformance-kind-ipv6-parallel

[tkashem]

{Failed === RUN TestCreateHealthcheck/timeouts_if_response_time_higher_than_default_timeout
factory_test.go:141: healthcheck() missmatch want context deadline exceeded got etcd client connection not yet established
--- FAIL: TestCreateHealthcheck/timeouts_if_response_time_higher_than_default_timeout (1.00s)
}

/test pull-kubernetes-unit

[tkashem]

it's ready for another pass, thanks!

[MikeSpreitzer]

/LGTM
Thanks!

[wojtek-t]

/cc

[cici37]

Couple questions:

1. Since the patch annotation is added and the controller switched to use v1beta3, should [reset_fields_test.go](

   kubernetes/test/integration/apiserver/apply/reset_fields_test.go

   Lines 73 to 77 in c012d90

   	var resetFieldsSkippedResources = map[string]struct{}{
   	// TODO: flowschemas is flaking,
   	// possible bug in the flowschemas controller.
   	"flowschemas": {},
   	}

   ) updated now?
2. Maybe worth to keep in mind(Could be added in a followup as well): test/integration/apiserver/flowcontrol/fs_condition_test.go
3. If we plan to address 1, maybe mention this PR will fix flowschemas resource is currently skipped by TestApplyResetFields test. #104842
4. Could be a followup PR: update lifecycle directives on old flowcontrol versions to point to new v1beta3 version
   e.g. https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/api/flowcontrol/v1beta1/types.go#L108 and v1alpha1 and v1beta2 types

Thank you! :)

[liggitt]

thanks for the API review, marking API changes as approved

looks like dropping the exclusion from reset_fields_test.go and making sure the test doesn't flake is the only outstanding thing for this PR

[tkashem]

looks like dropping the exclusion from reset_fields_test.go and making sure the test doesn't flake is the only outstanding thing for this PR

I have an open PR #112575 for that. I also tested locally.

stress test on TestApplyResetFields, on master (flowschemas is skipped) - 1000 runs and 0 failure

$ go test -c ./test/integration/apiserver/apply/
$ stress ./apply.test -test.run=TestApplyResetFields
5s: 0 runs so far, 0 failures
10s: 5 runs so far, 0 failures
...
18m50s: 1014 runs so far, 0 failures

stress test on TestApplyResetFields, on master (flowschemas is not skipped): 2 failures within first 8 runs

$ stress ./apply.test -test.run=TestApplyResetFields
5s: 0 runs so far, 0 failures
10s: 4 runs so far, 1 failures (25.00%)
15s: 8 runs so far, 2 failures (25.00%)

stress test on TestApplyResetFields, on this PR (flowschemas is not skipped): 1000 runs, no failure

$ stress ./apply.test -test.run=TestApplyResetFields
5s: 0 runs so far, 0 failures
10s: 2 runs so far, 0 failures
...
21m35s: 1101 runs so far, 0 failures
21m40s: 1104 runs so far, 0 failures

Once we merge #112575, I will keep an eye on CI just to make sure we don't see the flakes.

[liggitt]

/approve

[liggitt]

sounds good, can fast-follow this PR with #112575

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, MikeSpreitzer, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• api/OWNERS [liggitt]
• cmd/kube-apiserver/OWNERS [liggitt]
• hack/OWNERS [liggitt]
• pkg/apis/OWNERS [liggitt]
• pkg/controlplane/OWNERS [liggitt]
• pkg/generated/openapi/OWNERS [liggitt]
• pkg/printers/OWNERS [liggitt]
• pkg/registry/OWNERS [liggitt]
• staging/src/k8s.io/api/OWNERS [liggitt]
• staging/src/k8s.io/apiserver/OWNERS [liggitt]
• staging/src/k8s.io/apiserver/pkg/apis/OWNERS [liggitt]
• staging/src/k8s.io/client-go/OWNERS [liggitt]
• test/e2e/apimachinery/OWNERS [liggitt]
• test/integration/apiserver/OWNERS [liggitt]
• test/integration/etcd/OWNERS [liggitt]
• vendor/OWNERS [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tkashem]

@cici37 thanks for the review!

Since the patch annotation is added and the controller switched to use v1beta3, ) should reset_fields_test.go be updated now?

Yes, #112575

Could be a followup PR: update lifecycle directives on old flowcontrol versions to point to new v1beta3 version

#112832

[wojtek-t]

Great to see it merged - thanks!