Fix load-balancer firewall messages

[thockin]

No description provided.

[thockin]

@bgrant0607 @bprashanth

[bprashanth]

Nit: since this is kubectl, it feels like we can confirm and tell them one way or another (not expecting it in this pr).

[thockin]

Ai gree we could, but we pretty much need that to come from the
cloud-provider, which means from the master.

#11259

On Tue, Jul 14, 2015 at 1:12 PM, Prashanth B notifications@github.com
wrote:

In pkg/kubectl/cmd/create.go
#11254 (comment)
:

        out.Write([]byte(msg))
    }
    if obj.Spec.Type == api.ServiceTypeNodePort {

•       msg := fmt.Sprintf(`
  

•           You have exposed your service on an external port on all nodes in your cluster.
  

•           If you want to expose this service to the external internet, you may need to set up
  

- firewall rules for the service port(s) (%s) to serve traffic.

•           See https://github.com/GoogleCloudPlatform/kubernetes/tree/master/docs/services-firewalls.md for more details.
  

•           `, makePortsString(obj.Spec.Ports, true))
  

•       msg := fmt.Sprintf(
  

•           `You have exposed your service on an external port on all nodes in your
  

  +cluster. If you want to expose this service to the external internet, you may
  +need to set up firewall rules for the service port(s) (%s) to serve traffic.
  +
  +See http://releases.k8s.io/HEAD/docs/services-firewalls.md for more details.

Nit: since this is kubectl, it feels like we can confirm and tell them one
way or another (not expecting it in this pr).

—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/11254/files#r34613478
.

[bprashanth]

LGTM

[k8s-bot]

GCE e2e build/test passed for commit 8da6aef5acf9933e93890810aa304c033f30737a.

• Build Log
• Test Artifacts
• Internal Jenkins Results

[k8s-bot]

GCE e2e build/test passed for commit 670141b1973dedc64123b4fb2dcf090527420522.

• Build Log
• Test Artifacts
• Internal Jenkins Results

[k8s-bot]

GCE e2e build/test passed for commit 85a56ce6d3efa9c42c253c9968125630263e4316.

• Build Log
• Test Artifacts
• Internal Jenkins Results

[k8s-bot]

GCE e2e build/test passed for commit 9005c5b4d89ba2218b8afc1ef230728f84971304.

• Build Log
• Test Artifacts
• Internal Jenkins Results

[bgrant0607]

I'd prefer to eliminate the message than to just fix formatting. We don't have warnings about privileged mode, use of PD, or anything else that requires external action by the user.

If we're not going to eliminate it, how about we reduce it to 1 line:

See the [Services and Firewalls doc](docs/services-firewalls.md) regarding opening of firewalls for the service.

docs/services-firewalls.md is out of date, though. It still instructs GCE users to open the firewall with gcloud.

[thockin]

OK, message removed, docs updated.

On Tue, Jul 14, 2015 at 8:35 PM, Brian Grant notifications@github.com
wrote:

I'd prefer to eliminate the message than to just fix formatting. We don't
have warnings about privileged mode, use of PD, or anything else that
requires external action by the user.

If we're not going to eliminate it, how about we reduce it to 1 line:

See the Services and Firewalls doc regarding opening of firewalls for the service.

docs/services-firewalls.md is out of date, though. It still instructs GCE
users to open the firewall with gcloud.

—
Reply to this email directly or view it on GitHub
#11254 (comment)
.

[bgrant0607]

LGTM
Thanks.

[bgrant0607]

cc @davidopp, who is planning to move services-firewalls.md

[k8s-bot]

GCE e2e build/test failed for commit 182b0a98e57b4f7e5a35afdb76a69f98927568f2.

• Build Log
• Test Artifacts
• Internal Jenkins Results

[k8s-bot]

GCE e2e build/test passed for commit 2d4df16215e77e27e22142074df2b6961a93d7d9.

• Build Log
• Test Artifacts
• Internal Jenkins Results

[k8s-bot]

GCE e2e build/test passed for commit fe89298.

• Build Log
• Test Artifacts
• Internal Jenkins Results

[bgrant0607]

all green

let's merge now before @davidopp re-creates his PR to move services-firewalls.md.

[davidopp]

It seems weird to have services-firewall.md at the top-level of the docs tree, but I couldn't decide where to put it, so I left it there in my PR. It seems like it belongs in user-guide?

[davidopp]

(My PR actually didn't move services-firewall.md, because I couldn't figure out which subdir to put it in.)

[thockin]

I'd say user-guide

On Wed, Jul 15, 2015 at 2:23 AM, David Oppenheimer <notifications@github.com

wrote:

(My PR actually didn't move services-firewall.md, because I couldn't
figure out which subdir to put it in.)

—
Reply to this email directly or view it on GitHub
#11254 (comment)
.