Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider only plugin subpath when cleaning up mounts #112607

Merged
merged 1 commit into from Sep 23, 2022
Merged

Consider only plugin subpath when cleaning up mounts #112607

merged 1 commit into from Sep 23, 2022

Conversation

mattcary
Copy link
Contributor

/kind bug

Fixes #112606

/assign @msau42
/sig storage

Consider only plugin directory and not entire kubelet root when cleaning up mounts

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. sig/storage Categorizes an issue or PR as relevant to SIG Storage. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 20, 2022
@k8s-ci-robot
Copy link
Contributor

@mattcary: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Sep 20, 2022
@mattcary mattcary force-pushed the ubuntu-path branch 2 times, most recently from d1f91de to 1be20d1 Compare September 20, 2022 18:13
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 20, 2022
msau42
msau42 reviewed Sep 20, 2022
View reviewed changes
pkg/volume/util/util.go
func HasMountRefs(mountPath string, mountRefs []string) bool {
// A mountPath typically is like
// /var/lib/kubelet/plugins/kubernetes.io/some-plugin/mounts/volume-XXXX
// Mount refs can look like
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment saying that a path like this is something we do want to count? From the logic below, we won't count this right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I clarified the comment (at least to my understanding).

@mattcary mattcary force-pushed the ubuntu-path branch 2 times, most recently from d2f416e to 166cb4a Compare September 20, 2022 23:52
@mattcary
Make mount ref search more robust
3993c23 
Change-Id: Id28c2d1c8e996c10e4ad19a993ebbe75b142c1af
@mattcary
Copy link
Contributor Author

/hold

I need to test this on a GKE sandbox before submitting to double-check it fixes the ephemeral storage issue.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2022
@mattcary
Copy link
Contributor Author

/cancel hold

I tested this manually and it fixes the problem with a local-ssd mounted kubelet on an ubuntu image \o/

/retest

(the unittest failure seems to be a flake, it passes locally)

@msau42
Copy link
Member

msau42 commented Sep 22, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2022
@mattcary
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2022
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit 91a9ce2 into kubernetes:master Sep 23, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 23, 2022
This was referenced Oct 7, 2022
Closed
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Oct 14, 2022
@k8s-ci-robot
Merge pull request #112921 from mattcary/robust-1.23
d7b7cfd 
Cherry pick #112607 Make mount ref search more robust
k8s-ci-robot added a commit that referenced this pull request Oct 14, 2022
@k8s-ci-robot
Merge pull request #112887 from mattcary/cp-ubuntu
9c548c3 
Cherry pick #112607 Make mount ref search more robust
k8s-ci-robot added a commit that referenced this pull request Oct 14, 2022
@k8s-ci-robot
Merge pull request #112920 from mattcary/robust-1.24
11eef1b 
Cherry pick #112607 Make mount ref search more robust
@huww98 huww98 mentioned this pull request Nov 7, 2023
Merged
@huww98 huww98 mentioned this pull request Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@gnufied gnufied Awaiting requested review from gnufied

@humblec humblec Awaiting requested review from humblec

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

Kubelet mount path cleanup can get confused depending on kubelet root mount point
4 participants
@mattcary @k8s-ci-robot @msau42 @k8s-triage-robot