Better handling of ginkgo args in jenkins #11291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice fix - LGTM |
|
GCE e2e build/test passed for commit 4b409b81d29794366bd65fac0a9d79f7dd4ced66. |
|
GCE e2e build/test failed for commit 38d51f3. |
|
LGTM |
davidopp
added
lgtm
|
@k8s-bot test this please |
|
GCE e2e build/test passed for commit 38d51f3. |
|
LGTM, thanks. |
|
I'm not merging any code until Jenkins is green for a turn. |
erictune
added a commit
that referenced
this pull request
Jul 15, 2015
Better handling of ginkgo args in jenkins
erictune
added a commit
to erictune/kubernetes
that referenced
this pull request
Jan 22, 2016
Was marked as flaky prior to kubernetes#11291, 6 months ago. Code has changed many times. No flakes in last 28 runs, and no Jenkins history before that. Follow up in kubernetes#19024 if you see a flake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wojtek-t